444 Commits

Author	SHA1	Message	Date
Maks Litskevich	cfcb946d28	Replace/extract opcodes for fast interp	2024-11-25 14:01:57 +00:00
Wenyong Huang	7b704e467e	Merge pull request #3925 from bytecodealliance/main ... Merge branch main into dev/simd_for_interp	2024-11-23 09:17:00 +08:00
Maks Litskevich	c3601cc4bd	Fix replacement value not being correct (#3919)	2024-11-22 19:39:33 +08:00
TianlongLiang	0e4dffc479	Fix a leak in wasm_loader_emit_br_info (#3900) ... Reference Info: 377955855 wamr:wasm_mutator_fuzz_loader: Direct-leak in wasm_loader_emit_br_info https://issues.oss-fuzz.com/issues/377955855	2024-11-13 15:16:13 +08:00
Maks Litskevich	fbbcd08b3c	Emit imm for lane extract and replace (#3906)	2024-11-13 15:10:46 +08:00
James Ring	fdda259d36	Fix linked global initialization in multimodule (#3905) ... While resolving linked globals in multi-module mode, WAMR tries to copy the linked global's initial value into the destination global in the current module. However, a bug in the implementation causes the copy to be done from the InitializerExpression struct, not from its WASMValue field. This did not come up in WAMR's spec test runner because those are built with WASM_ENABLE_SPEC_TEST, which means these globals are resolved as builtins, not linked globals, which goes through a different (presumably not faulty) path.	2024-11-13 14:52:27 +08:00
TianlongLiang	bf78863c56	Wasm loader enhancement: check code size in code entry (#3892) ... add wasm loader check: in code entry, the code size should match the size of vec(locals) + expr, and expr should end with opcode end	2024-11-07 13:38:42 +08:00
jammar1	c930c4d199	Add first NEON SIMD opcode implementations to fast interpreter (#3859) ... Add some implementations of SIMD opcodes using NEON instructions. Tested using: ```wast (module (import "wasi_snapshot_preview1" "proc_exit" (func $proc_exit (param i32))) (memory (export "memory") 1) (func $assert_true (param v128) local.get 0 v128.any_true i32.eqz if unreachable end ) (func $main (export "_start") i32.const 0 i32.const 32 memory.grow drop i32.const 0 v128.const i8x16 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 v128.store i32.const 0 v128.load v128.const i8x16 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 i8x16.eq call $assert_true i32.const 16 v128.const i8x16 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 v128.store i32.const 16 v128.load v128.const i8x16 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 i8x16.eq call $assert_true i32.const 0 v128.load v128.const i8x16 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 i8x16.eq call $assert_true drop i32.const 0 i32.const 1 memory.grow drop i32.const 0 i64.const 0x7F80FF017E02FE80 i64.store i32.const 0 v128.load8x8_s v128.const i16x8 127 -128 -1 1 126 2 -2 -128 i16x8.eq call $assert_true i32.const 0 i64.const 0x80FE027E01FF807F i64.store i32.const 0 v128.load8x8_u v128.const i16x8 128 254 2 126 1 255 128 127 i16x8.eq call $assert_true i32.const 0 i64.const 0x8000FFFE7FFF0001 i64.store i32.const 0 v128.load16x4_s v128.const i32x4 -32768 -2 32767 1 i32x4.eq call $assert_true i32.const 0 i64.const 0x8000FFFE7FFF0001 i64.store i32.const 0 v128.load16x4_u v128.const i32x4 32768 65534 32767 1 i32x4.eq call $assert_true i32.const 0 i64.const 0x8000000000000001 i64.store i32.const 0 v128.load32x2_s v128.const i64x2 -2147483648 1 i64x2.eq call $assert_true i32.const 0 i64.const 0x8000000000000001 i64.store i32.const 0 v128.load32x2_u v128.const i64x2 2147483648 1 i64x2.eq call $assert_true call $proc_exit ) ) ```	2024-11-06 07:58:15 +08:00
Wenyong Huang	aceaed65cc	Merge pull request #3873 from bytecodealliance/main ... Merge branch main into dev/simd_for_interp	2024-10-23 16:56:30 +08:00
Maks Litskevich	6426fc4993	Fix out of bounds issues after memory.grow on non-aot non-threads builds (#3872) ... Co-authored-by: Deniz Sokmen <dsokmen@amazon.com>	2024-10-23 14:48:40 +08:00
James Ring	3ad95303d6	Fix quadratic runtime for duplicate export name detection (#3861) ... Previously, the loader would check the name of a new export against all existing exports, leading to a quadratic running time. This change makes the loader parse the entire export section. The exports are then sorted by name, then adjacent exports are checked for uniqueness.	2024-10-21 11:02:30 +08:00
Wenyong Huang	87588caa7f	Fix lookup function issue reported in nightly run (#3868)	2024-10-21 09:57:42 +08:00
Wenyong Huang	48eaa2286a	Refine wasm/aot function instance lookup (#3865) ... Sort the module instance's export functions with the function name, and use binary search to lookup the wasm/aot function.	2024-10-18 15:15:33 +08:00
James Marsh	c1bfe2abd6	Add V128 comparison operations ... Tested using ``` (module (import "wasi_snapshot_preview1" "proc_exit" (func $proc_exit (param i32))) (memory (export "memory") 1) (func $assert_true (param v128) local.get 0 v128.any_true i32.eqz if unreachable end ) (func $main (export "_start") ;; Test v128.not v128.const i8x16 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 v128.not v128.const i8x16 255 255 255 255 255 255 255 255 255 255 255 255 255 255 255 255 i8x16.eq call $assert_true ;; Test v128.and v128.const i8x16 255 255 255 255 0 0 0 0 255 255 255 255 0 0 0 0 v128.const i8x16 255 255 0 0 255 255 0 0 255 255 0 0 255 255 0 0 v128.and v128.const i8x16 255 255 0 0 0 0 0 0 255 255 0 0 0 0 0 0 i8x16.eq call $assert_true ;; Test v128.andnot v128.const i8x16 255 255 255 255 0 0 0 0 255 255 255 255 0 0 0 0 v128.const i8x16 255 255 0 0 255 255 0 0 255 255 0 0 255 255 0 0 v128.andnot v128.const i8x16 0 0 255 255 0 0 0 0 0 0 255 255 0 0 0 0 i8x16.eq call $assert_true ;; Test v128.or v128.const i8x16 255 255 0 0 0 0 255 255 255 255 0 0 0 0 255 0 v128.const i8x16 0 0 255 255 255 255 0 0 0 0 255 255 255 255 0 0 v128.or v128.const i8x16 255 255 255 255 255 255 255 255 255 255 255 255 255 255 255 0 i8x16.eq call $assert_true ;; Test v128.xor v128.const i8x16 255 255 0 0 255 255 0 0 255 255 0 0 255 255 0 0 v128.const i8x16 255 255 255 255 0 0 0 0 255 255 255 255 0 0 0 0 v128.xor v128.const i8x16 0 0 255 255 255 255 0 0 0 0 255 255 255 255 0 0 i8x16.eq call $assert_true i32.const 0 call $proc_exit ) ) ```	2024-10-15 13:47:59 +01:00
James Marsh	5b2ab61243	Add all SIMD operations into wasm_interp_fast switch	2024-10-15 13:38:27 +01:00
Wenyong Huang	b038f2721b	Merge pull request #3823 from bytecodealliance/dev/shared_heap ... Implement the shared heap feature for interpreter, aot and llvm jit. Add below runtime APIs: ```C wasm_shared_heap_t wasm_runtime_create_shared_heap(SharedHeapInitArgs *init_args); bool wasm_runtime_attach_shared_heap(wasm_module_inst_t module_inst, wasm_shared_heap_t shared_heap); void wasm_runtime_detach_shared_heap(wasm_module_inst_t module_inst); uint64_t wasm_runtime_shared_heap_malloc(wasm_module_inst_t module_inst, uint64_t size, void **p_native_addr); void wasm_runtime_shared_heap_free(wasm_module_inst_t module_inst, uint64_t ptr); ``` And allow wasm app to call API shared_heap_malloc and shared_heap_free: ```C void *shared_heap_malloc(uint32_t size); void shared_heap_free(void *ptr); ```	2024-10-15 14:26:22 +08:00
TianlongLiang	36d438051e	Support table64 extension in classic-interp and AOT running modes (#3811) ... Add table64 extension(in Memory64 proposal) support in classic-interp and AOT running modes, currently still use uint32 to represent table's initial and maximum size to keep AOT ABI unchanged.	2024-10-11 21:14:56 +08:00
Wenyong Huang	deacb7a8d8	Fix exec_env_tls assertion in module instantiation (#3844) ... The execute_post_instantiate_functions may be triggered by wasm_cluster_spawn_exec_env, in which the exec_env_tls can be NULL and cause the assertion invalid. p.s. https://github.com/bytecodealliance/wasm-micro-runtime/issues/3839.	2024-10-08 10:08:29 +08:00
James Ring	6b4d8aae2a	Emit load_addr and load_size if WAMR_ENABLE_COMPILER is set (#3835) ... Currently, the open-source builds of wamrc set WASM_ENABLE_DUMP_CALL_STACK, which causes these two fields to be emitted. They are required by aot_emit_exception.c. Internally at Google, we don't enable call stack dumps, so we've been using the attached patch to make sure the fields are emitted anyway.	2024-10-08 09:28:24 +08:00
Marcin Kolny	860379bc58	implement POP_V128() ... This is to simplify the simd implementation for fast interpreter	2024-10-01 11:15:14 +01:00
Wenyong Huang	9ba36e284c	Implement shared heap for AOT (#3815)	2024-09-29 12:50:59 +08:00
Marcin Kolny	326aea298c	Implement the first few SIMD opcodes for fast interpreter (v128.const, v128.any_true) (#3818) ... Tested on the following code: ``` (module (import "wasi_snapshot_preview1" "proc_exit" (func $proc_exit (param i32))) (memory (export "memory") 1) ;; WASI entry point (func $main (export "_start") v128.const i8x16 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 v128.any_true if unreachable end v128.const i8x16 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 v128.any_true i32.const 0 i32.eq if unreachable end i32.const 0 call $proc_exit ) ) ```	2024-09-28 07:00:49 +08:00
palchikov	86926aa9d2	Fix unused param warning when GC is enabled (#3814)	2024-09-25 16:59:52 +08:00
Wenyong Huang	1fd422ae6e	Merge branch main into dev/shared_heap	2024-09-20 14:34:00 +08:00
WenLY1	4dacef2d60	shared heap: Fix some issues and add basic unit test case (#3801) ... Fix some issues and add basic unit test case for shared heap feature. Signed-off-by: wenlingyun1 <wenlingyun1@xiaomi.com>	2024-09-20 14:24:38 +08:00
Anders Bakken	21330990a8	Add no_resolve to LoadArgs and wasm_runtime_resolve_symbols (#3790) ... Add no_resolve to LoadArgs and wasm_runtime_resolve_symbols so one can delay resolving of symbols. This is useful for inspecting the module between loading and instantiating.	2024-09-20 08:54:09 +08:00
Wenyong Huang	5e20cf383e	Refactor shared heap feature for interpreter mode (#3794) ... To add test cases and samples.	2024-09-18 14:53:41 +08:00
WenLY1	92852f3719	Implement a first version of shared heap feature (#3789) ... ps. https://github.com/bytecodealliance/wasm-micro-runtime/issues/3546	2024-09-14 10:51:42 +08:00
Benbuck Nason	926f662231	Add memory instance support apis (#3786) ... Now that WAMR supports multiple memory instances, this PR adds some APIs to access them in a standard way. This involves moving some existing utility functions out from the `WASM_ENABLE_MULTI_MODULE` blocks they were nested in, but multi-memory and multi-module seem independent as far as I can tell so I assume that's okay. APIs added: ```C wasm_runtime_lookup_memory wasm_runtime_get_default_memory wasm_runtime_get_memory wasm_memory_get_cur_page_count wasm_memory_get_max_page_count wasm_memory_get_bytes_per_page wasm_memory_get_shared wasm_memory_get_base_address wasm_memory_enlarge ```	2024-09-14 10:31:13 +08:00
Benbuck Nason	c276aca202	Fix compile error when multi-module and tags are enabled (#3781)	2024-09-10 09:55:15 +08:00
YAMAMOTO Takashi	f453d9d5ce	Appease GCC strict prototypes warning (#3775)	2024-09-10 09:42:23 +08:00
Marcin Kolny	cbc2078898	AOT call stack optimizations (#3773) ... - Implement TINY / STANDARD frame modes - tiny mode is only able to keep track on the IP and func idx, STANDARD mode provides more capabilities (parameters, stack pointer etc.). - Implement FRAME_PER_FUNCTION / FRAME_PER_CALL modes - frame per function adds code at the beginning and at the end of each function for allocating / deallocating stack frame, whereas in per-call mode the frame is allocated before each call. The exception is call to the imported function, where frame-per-function mode also allocates the stack before the `call` instruction (as it can't instrument the imported function). At the moment TINY + FRAME_PER_FUNCTION is automatically enabled in case GC and perf profiling are disabled and `values` call stack feature is not requested. In all the other cases STANDARD + FRAME_PER_CALL is used. STANDARD + FRAME_PER_FUNCTION and TINY + FRAME_PER_CALL are currently not implemented but possible, and might be enabled in the future. ps. https://github.com/bytecodealliance/wasm-micro-runtime/issues/3758	2024-09-10 09:05:23 +08:00
Marcin Kolny	6f97822c18	Add wamrc parameter to configure stack frame features (#3763) ... Those parameters can be used to reduce the size of the AOT code. There's going to be more changes related to AOT code size reduction, this is just the initial step. p.s. https://github.com/bytecodealliance/wasm-micro-runtime/issues/3758	2024-09-05 21:44:06 +08:00
TianlongLiang	d1141f6f30	aot compiler: Allow to control stack boundary check when boundary check is enabled (#3754) ... In the AOT compiler, allow the user to control stack boundary check when the boundary check is enabled (e.g. `wamrc --bounds-checks=1`). Now the code logic is: 1. When `--stack-bounds-checks` is not set, it will be the same value as `--bounds-checks`. 2. When `--stack-bounds-checks` is set, it will be the option value no matter what the status of `--bounds-checks` is.	2024-08-29 11:08:39 +08:00
Wenyong Huang	1329e1d3e1	Add support for multi-memory proposal in classic interpreter (#3742) ... Implement multi-memory for classic-interpreter. Support core spec (and bulk memory) opcodes now, and will support atomic opcodes, and add multi-memory export APIs in the future. PS: Multi-memory spec test patched a lot for linking test to adapt for multi-module implementation.	2024-08-21 12:22:23 +08:00
Wenyong Huang	97c95a2e2f	Fix table idx resolving in op call_indirect/return_call_indirect (#3726) ... The table index in the call_indirect/return_call_indirect opcode should be one byte 0x00 when ref-types/GC isn't enabled, and should be treated as leb u32 when ref-types/GC is enabled. And make aot compiler bail out if ref-types/GC is disabled by command line argument while ref-types instructions are used.	2024-08-19 10:57:36 +08:00
Jan Olaf Martin	59f761b58d	aot compiler: Track non-0x00 tableindex as ref types use (#3695) ... Any use of a table index that isn't exactly a null byte (`0x00`) means that the module makes use of the reference types proposal. This is important to track because `aot_compiler.c` will blindly assume that all table indices are a single byte long otherwise. This fixes a crash in WAMR for modules that contain multi-byte encodings of table indices in `call_indirect` but make no other use of reference types features.	2024-08-16 12:37:10 +08:00
Wenyong Huang	da25906ed4	debug-interp: Only add lock when signal_flag is SIG_SINGSTEP (#3704) ... As reported in #3500, when debug interpreter is enabled, the classic interpreter performs a lock operation to read `exec_env->current_status->signal_flag` and do further handling before fetching next opcode, which makes the interpreter run slower. This PR atomic loads the `exec_env->current_status->signal_flag` without mutex lock when 32-bit atomic load is supported, and only adding lock for further handling when the signal_flag is WAMR_SIG_SINGSTEP, which improves the performance.	2024-08-14 09:03:01 +08:00
Marcin Kolny	37d7439ef9	[refactoring] Extract read leb to a separate file, share the code between loader and mini loader (#3701) ... There's probably a number of other places where the bh_leb_read could be used (e.g. aot loader) but I'm making the change as small as possible. Further refactoring can be done later.	2024-08-14 08:46:24 +08:00
YAMAMOTO Takashi	50f28495a1	Remove a few hardcoded spec test knowledge from the core library (#3648) ... Tweak the stack sizes in the spec test runner instead.	2024-07-22 13:30:00 +08:00
Benbuck Nason	501d7d5adf	Add apis to get package version (#3601) ... Add three APIs: - wasm_runtime_get_file_package_version - wasm_runtime_get_module_package_version - wasm_runtime_get_current_package_version	2024-07-16 08:15:59 +08:00
Wenyong Huang	73caf19e69	Fix compile warnings/error reported in Windows (#3616) ... Clear some compile warnings and fix undefined reference error for symbol ffs in Windows platform.	2024-07-12 16:43:22 +08:00
YAMAMOTO Takashi	46695b992c	EH: Use the consistent type for EH handlers (#3619) ... The "handlers" on the interpreter stack is sometimes treated as host pointers and sometimes treated as i64 values. It's quite broken for targets where pointers are not 64-bit. This commit makes them host pointers consistently. (at least for 32-bit and 64-bit pointers. We don't support other pointer sizes anyway.) Fixes https://github.com/bytecodealliance/wasm-micro-runtime/issues/3110	2024-07-12 11:00:55 +08:00
YAMAMOTO Takashi	1b1ec715e9	wasm loader: Reject v128 for interpreters (#3611) ... discussed in: https://github.com/bytecodealliance/wasm-micro-runtime/pull/3592	2024-07-10 13:50:52 +08:00
Benbuck Nason	8aba85825c	Avoid redefining WASMMemoryType (#3602)	2024-07-10 10:05:47 +08:00
Wenyong Huang	0feae05379	wasm loader: Fix several issues in GC and exception handling (#3586) ... Fix several issues of GC and exception handling in wasm loader: - Should restore param_reftype_maps/param_reftype_map_count/param_count in the handling of opcode throw - Should set wasm_ref_type when pushing param types of tag type and block type if the type is a multi-byte type - Should set init_values.data as NULL for opcode struct.new_default in load_init_expr This PR fixes the issues reported in #3411.	2024-07-05 19:15:58 +08:00
Wenyong Huang	1f94cd4ee5	wasm loader: Fix push_frame_offset when pushing v128 type (#3588) ... Fixes issue https://github.com/bytecodealliance/wasm-micro-runtime/issues/3580.	2024-07-03 15:18:42 +08:00
liang.he	f118492b1d	Add integer overflow check for some indices in wasm/aot loader (#3579) ... Check whether the indices overflow UINT32_MAX or not for: - import function count + function count - import global count + global count - import tag count + tag count This PR fixes the issue reported by Oss-fuzz test (#69920).	2024-07-02 15:48:37 +08:00
TianlongLiang	a5753ea920	interp debugger: Fix setting invalid value to step_count (#3583) ... The `exec_env->current_status->step_count` should be set same as the handling when WASM_ENABLE_LABELS_AS_VALUES is not 0. Fixes issue https://github.com/bytecodealliance/wasm-micro-runtime/issues/3475.	2024-07-02 11:03:49 +08:00
Xenia Lu	f7d2826772	Allow missing imports in wasm loader and report error in wasm instantiation instead (#3539) ... The wasm loader is failing when multi-module support is on and the dependent modules are not found; this enforces the AOT compiler integrations to prepare dependent modules while it isn't necessary. This PR allows allows missing imports in wasm loader and report error in wasm instantiation instead, which enables the integrated AOT compiler to work as if the multi-module support isn't turned on.	2024-06-25 10:04:39 +08:00