1082 Commits

Author	SHA1	Message	Date
Xenia Lu	54b87cb097	Fix missing stack frame alloc/free in AOT multi-module invoke (#3562) ... Fix #3545 and update the build configuration for multi-module sample: - pass debug to AOT-compiled modules - support optional DUMP_CALL_STACK - support optional GC	2024-06-24 13:56:11 +08:00
liang.he	d36160b294	wasi-nn: Add wasmedge-wasinn-example as smoke test (#3554)	2024-06-24 12:03:08 +08:00
liang.he	cfffb62ad2	aot loader: Verify global value type (#3560) ... Fix issue reported by Oss-fuzz test (#69798). https://oss-fuzz.com/testcase-detail/5963842371256320	2024-06-24 10:34:03 +08:00
liang.he	95f7717555	aot loader: Add more checks in load_native_symbol_section() (#3559) ... Fix issue reported by Oss-fuzz test (#69675).	2024-06-24 10:07:10 +08:00
YAMAMOTO Takashi	4c2af25aff	aot compiler: Use larger alignment for load/store when possible (#3552) ... Consider the following wasm module: ```wast (module (func (export "foo") i32.const 0x104 i32.const 0x12345678 i32.store ) (memory 1 1) ) ``` While the address (0x104) is perfectly aligned for i32.store, as our aot compiler uses 1-byte alignment for load/store LLVM IR instructions, it often produces inefficient machine code, especially for alignment-sensitive targets. For example, the above "foo" function is compiled into the following xtensa machine code. ``` 0000002c <aot_func_internal#0>: 2c: 004136 entry a1, 32 2f: 07a182 movi a8, 0x107 32: 828a add.n a8, a2, a8 34: 291c movi.n a9, 18 36: 004892 s8i a9, a8, 0 39: 06a182 movi a8, 0x106 3c: 828a add.n a8, a2, a8 3e: ffff91 l32r a9, 3c <aot_func_internal#0+0x10> (ff91828a <aot_func_internal#0+0xff91825e>) 3e: R_XTENSA_SLOT0_OP .literal+0x8 41: 004892 s8i a9, a8, 0 44: 05a182 movi a8, 0x105 47: 828a add.n a8, a2, a8 49: ffff91 l32r a9, 48 <aot_func_internal#0+0x1c> (ffff9182 <aot_func_internal#0+0xffff9156>) 49: R_XTENSA_SLOT0_OP .literal+0xc 4c: 41a890 srli a10, a9, 8 4f: 0048a2 s8i a10, a8, 0 52: 04a182 movi a8, 0x104 55: 828a add.n a8, a2, a8 57: 004892 s8i a9, a8, 0 5a: f01d retw.n ``` Note that the each four bytes are stored separately using one-byte-store instruction, s8i. This commit tries to use larger alignments for load/store LLVM IR instructions when possible. with this commit, the above example is compiled into the following machine code, which seems more reasonable. ``` 0000002c <aot_func_internal#0>: 2c: 004136 entry a1, 32 2f: ffff81 l32r a8, 2c <aot_func_internal#0> (81004136 <aot_func_internal#0+0x8100410a>) 2f: R_XTENSA_SLOT0_OP .literal+0x8 32: 416282 s32i a8, a2, 0x104 35: f01d retw.n ``` Note: this doesn't work well for --xip because aot_load_const_from_table() hides the constness of the value. Maybe we need our own mechanism to propagate the constness and the value.	2024-06-22 10:32:52 +08:00
Benbuck Nason	e8df3b5c48	Consistent const keyword position in wasm_export.h (#3558)	2024-06-21 11:40:34 +08:00
Benbuck Nason	7d3bac62af	Add linked field comment for aot import type (#3557)	2024-06-21 10:24:56 +08:00
Wenyong Huang	9b9e938bee	Fix compilation errors (#3549) ... The compilation errors were introduced by #3515 and occur in debug building when wasm mini loader is compiled or GC is enabled. And remove two wasm files in standalone test-running-modes case, which will be generated by run.sh.	2024-06-20 12:33:52 +08:00
Florian Castellane	0418041b0d	wasm_memory.c: Fix typo: hasn't been initialize -> hasn't been initialized (#3547)	2024-06-19 17:02:09 +08:00
YAMAMOTO Takashi	a16da4f874	dwarf_extractor.cpp: Try to preserve link name (#3542) ... mainly for C++.	2024-06-19 16:51:44 +08:00
YAMAMOTO Takashi	7f94d183ac	dwarf_extractor.cpp: Fix buffer overruns (#3541) ... Probably it's better to skip the optimized out parameters. (that is, parameters w/o locations) However, I'm not sure how/if it can be done with the lldb api. For now, just disable parameter processing to avoid crashes.	2024-06-19 16:19:57 +08:00
Benbuck Nason	3746534010	Add table type API support (#3515) ... Add `wasm_runtime_get_export_table_inst` and `wasm_table_get_func_inst`, and related wasm_table_type_get_xxx APIs.	2024-06-19 14:50:46 +08:00
YAMAMOTO Takashi	72f74b7b51	dwarf_extractor.cpp: Enable limited support for C++ (#3540) ... While band-aid fixes like this is not plausible IMO, some people prefer to have some debug info even if it's partial/limited/broken. This commit partially (re)enables C++ processing. On the other hand, do not bother to process variables because it's known incompatible with C++.	2024-06-18 15:42:56 +08:00
liang.he	fa8a80a115	aot loader: Prevent loading multiple native symbol sections (#3538) ... Don't allow to load multiple native symbol sections in aot loader since the aot compiler will create only one native symbol section. Fix issue reported by Oss-fuzz test (#69633).	2024-06-18 15:31:39 +08:00
liang.he	c19bc95391	Validate func type in aot loader (#3535) ... Fix issue reported by Oss-fuzz test (#69629).	2024-06-18 14:23:32 +08:00
YAMAMOTO Takashi	f096b2fa38	wamrc: Fix truncated DW_AT_producer (#3537)	2024-06-17 18:02:12 +08:00
liang.he	db025e457a	sync up with latest wasi-nn spec (#3530)	2024-06-17 14:58:09 +08:00
Wenyong Huang	d3e89895be	wasm loader: Fix pop invalid offset count when stack top is ANY (#3516) ... In wasm_loader_pop_frame_offset, when the stack is in polymorphic state and the stack top operand is VALUE_TYPE_ANY, if we popping I64/F64 operand, we should pop one offset but not two offsets. The issue was reported in #3513 and #3514.	2024-06-14 16:22:08 +08:00
Xenia Lu	ad5d31b9b0	Expose more functions related to emitting AOT files (#3520) ... - Add declarations related to emitting AOT files into a separate header file named `aot_emit_aot_file.h` - Add API `aot_emit_aot_file_buf_ex` and refactor `aot_emit_aot_file_buf` to call it - Expose some APIs in aot_export.h	2024-06-14 15:57:45 +08:00
liang.he	6621793acc	Fix two fuzz issues (#3529) ... - #69598: protect from `0-1` - #69608: in case no tailing `\0`	2024-06-14 15:42:21 +08:00
liang.he	f844b33b2d	Make wasi-nn backends as separated shared libraries (#3509) ... - All files under *core/iwasm/libraries/wasi-nn* are compiled as shared libraries - *wasi-nn.c* is shared between backends - Every backend has a separated shared library - If wasi-nn feature is enabled, iwasm will depend on shared library libiwasm.so instead of linking static library libvmlib.a	2024-06-14 12:06:56 +08:00
liang.he	40c41d5110	Fix several issues reported by oss-fuzz (#3526) ... - possible integer overflow in adjust_table_max_size: unsigned integer overflow: 2684354559 * 2 cannot be represented in type 'uint32' - limit max memory size in wasm_runtime_malloc - add more checks in aot loader - adjust compilation options	2024-06-13 16:06:36 +08:00
liang.he	028f43bc18	Fix compilation warnings of wasi-nn (#3497)	2024-06-07 10:49:44 +08:00
liang.he	bd44117676	Add wasi-nn example as smoke test case (#3501)	2024-06-07 10:26:09 +08:00
Benbuck Nason	5d1f19fc09	Fix wasm_mini_loader.c build when jit or multi-module is enabled (#3502) ... This PR fixes compilation error when building with `-DWAMR_BUILD_MINI_LOADER=1 -DWAMR_BUILD_JIT=1` or `-DWAMR_BUILD_MINI_LOADER=1 -DWAMR_BUILD_MULTI_MODULE=1`, though normally we don't use wasm mini loader when JIT or multi-module is enabled.	2024-06-06 09:53:22 +08:00
Benbuck Nason	8239dd4aa7	Add wasm_export.h APIs to expose memory type (#3496) ... Support to get `wasm_memory_type_t memory_type` from API `wasm_runtime_get_import_type` and `wasm_runtime_get_export_type`, and then get shared flag, initial page cout, maximum page count from the memory_type: ```C bool wasm_memory_type_get_shared(const wasm_memory_type_t memory_type); uint32_t wasm_memory_type_get_init_page_count(const wasm_memory_type_t memory_type); uint32_t wasm_memory_type_get_max_page_count(const wasm_memory_type_t memory_type); ```	2024-06-06 09:20:24 +08:00
Benbuck Nason	56b42908a8	Fix internal global getter types (#3495)	2024-06-04 11:29:31 +08:00
Wenyong Huang	0a80cc4e94	Fix wasm loader check data segment count (#3492) ... When datacount section exists, loader will check whether the data count read from data segment section is same with the data count read from datacount section, but the value of latter can be 0, loader should not skip the check when the latter is 0. This fixes #3491. And fix handle_name_section return value not checked issue and early return true issue after handle_name_section. And also add the failed case in #3491 to ba-issues.	2024-06-03 19:48:11 +08:00
TianlongLiang	ab4e17b701	Modify logging for windows exception handler and remove unused function (#3489) ... ps. https://github.com/bytecodealliance/wasm-micro-runtime/issues/3416 https://github.com/bytecodealliance/wasm-micro-runtime/issues/3400	2024-05-31 13:07:56 +08:00
Wenyong Huang	23e1d51587	Fix loader parse block type and calculate dynamic offset for loop args (#3482) ... Fix several issues in wasm loader: - Parse a block's type index with leb int32 instead leb uint32 - Correct dst dynamic offset of loop block arguments for opcode br when copying the stack operands to the arguments of loop block - Free each frame_csp's param_frame_offsets when destroy loader ctx - Fix compilation error in wasm_mini_loader.c - Add test cases of failed issues This PR fixes issue #3467 and #3468.	2024-05-31 11:32:36 +08:00
Wenyong Huang	5623e4d22a	Fix memory64 handling find_block_addr and execute_main (#3480)	2024-05-30 16:14:12 +08:00
liang.he	d29802c451	Fix two issues to make fuzzing test quit earlier (#3471) ... - Add a marco to limit the maxi allocable memory size of fuzz test to 2GB to avoid libFuzzer out-of-memory - Check global type in load_global_import and load_global_section	2024-05-30 14:55:21 +08:00
Enrico Loparco	3b8ef89110	Clone data segments when specified with load args (#3463) ... Follow-up on https://github.com/bytecodealliance/wasm-micro-runtime/pull/3389, specifically: https://github.com/bytecodealliance/wasm-micro-runtime/pull/3389#discussion_r1600872451 If we want to free the wasm binary buffer early, we need to clone the data segments into the module. That's because, in case of [passive data segments](https://webassembly.github.io/threads/core/syntax/modules.html#syntax-data), they can be referred during wasm execution.	2024-05-27 09:59:24 +08:00
Wenyong Huang	6fdfedb08a	Fix codeql compilation error (#3461) ... Update OS to ubuntu-22.04 and install `libgcc-12-dev lib32gcc-12-dev` instead of `libgcc-11-dev lib32gcc-11-dev`. And fix a bh_assert condition typo error. ps. https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/9183310069/job/25253782329	2024-05-22 17:27:38 +08:00
Wenyong Huang	f143344842	libc-builtin: Enhance buffered print for printf_wrapper (#3460) ... Move print_buf and print_buf to str_context struct to support multi-threading when BUILTIN_LIBC_BUFFERED_PRINTF macro is enabled, and fix the issue of losing some text. ps. https://github.com/bytecodealliance/wasm-micro-runtime/issues/3430.	2024-05-22 17:17:36 +08:00
Benbuck Nason	c5ab862dbb	Add api to get export global instance (#3452) ... Add API ```C bool wasm_runtime_get_export_global_inst(const wasm_module_inst_t module_inst, const char *name, wasm_global_inst_t *global_inst); ```	2024-05-22 16:59:44 +08:00
Wenyong Huang	15d191943a	Enhance GC const initializer expression to support nested struct/array new (#3447) ... Only support interpreter now, and fix some issues found in wasm loader. This PR fixes issue #3410 and #3411.	2024-05-21 16:09:12 +08:00
YAMAMOTO Takashi	403f472ff1	wasi: Tweak the configuration for nuttx and explain why (#3451)	2024-05-21 14:42:30 +08:00
TianlongLiang	30ed97cddc	Fix several typos and fix bh_log calculate mills (#3441)	2024-05-20 15:54:01 +08:00
Benbuck Nason	7744e84607	ssp_config.h: Fix ifdef for android random api (#3444) ... It looks like the preferred preprocessor check for Android is `__ANDROID__` instead of `ANDROID`: https://groups.google.com/g/android-ndk/c/cf9_f1SLXls Change `(defined(ANDROID) && __ANDROID_API__ < 28)` to `((defined(ANDROID) || defined(__ANDROID__)) && (__ANDROID_API__ < 28))`.	2024-05-18 20:23:34 +08:00
liang.he	b2eb7d838d	Update spec test to latest commit (#3293) ... - Update spec test cases to commit bc76fd79cfe61033d7f4ad4a7e8fc4f996dc5ba8 on Apr. 3 - Update wabt binary to 1.0.34 to support newer spec cases - Add comparison between table declared elem type and table elem segment value type - Add a function to decide whether to execute test cases in a running mode - Keep using interpreter in GC spec because wat2wasm in wabt can't compile if.wast w/o errors - Re-factoring threads spec test case processing - Since wabt 1.0.34 release isn't compatible with ubuntu 20.04, compile it from source code - Disable CI to run aot multi-module temporarily, and will enable it in another PR	2024-05-17 10:40:47 +08:00
Enrico Loparco	6b1d81650d	Allow not copying the wasm binary in wasm-c-api and not referring to the binary in wasm/aot loader (#3389) ... Add flag `LoadArgs.clone_wasm_binary` to control whether to clone the wasm/aot binary in wasm-c-api module. If false, API `wasm_module_new_ex` won't clone the binary, which may reduce the footprint. Add flag `LoadArgs.wasm_binary_freeable` to control whether the wasm/aot binary may be freed after instantiation for wamr API `wasm_runtime_load_ex`, if yes, then for some running modes, the wasm/aot module doesn't refer to the input binary again so developer can free it after instantiation to reduce the footprint. And add API `wasm_module_is_underlying_binary_freeable` and `wasm_runtime_is_underlying_binary_freeable` to check whether the input binary can be freed after instantiation for wasm-c-api and wamr api. And add sample to illustrate it.	2024-05-17 09:00:08 +08:00
YAMAMOTO Takashi	51ecfd6673	libc-wasi: Fix a locking botch (#3437)	2024-05-15 15:41:40 +08:00
Wenyong Huang	7949df96f4	Fix fast interp RECOVER_BR_INFO and local set/tee (#3434) ... When copying two cells from src offsets to dst offsets in RECOVER_BR_INFO, the offsets may be overlapped and the src data may be overwritten, use GET_I64_FROM_ADDR and then SET_I64_FROM_ADDR instead to resolve it. And handling VALUE_TYPE_FUNCREF/VALUE_TYPE_EXTERNREF for opcode local.set and local.tee when reference types feature is enabled. This PR fixes issue #3401 and #3402.	2024-05-15 15:20:21 +08:00
Wenyong Huang	49c9fa31da	Fix typo of WAMR_CONFIGUABLE_BOUNDS_CHECKS (#3424) ... Change to WAMR_CONFIGURABLE_BOUNDS_CHECKS, and fix CodeQL compilation errors which were introduced by PR #3406. ps. https://github.com/bytecodealliance/wasm-micro-runtime/pull/3393#discussion_r1591810998 https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/9055318553/job/24876266629	2024-05-14 14:33:09 +08:00
Benbuck Nason	0f17a1464e	Add comments to global type function declarations (#3431)	2024-05-14 11:38:18 +08:00
Wenyong Huang	773efc006d	Change WASM_ANYREF to WASM_EXTERNREF (#3426) ... wasm-c-api wasm.h had changed WASM_ANYREF to WASM_EXTERNREF, we had better change it in WAMR also: 2ce1367c9d/include/wasm.h (L185)	2024-05-14 11:08:16 +08:00
Benbuck Nason	dbd8790681	Add WASM_V128 in wasm_valkind_enum (#3412) ... Add WASM_V128 in wasm_valkind_enum and handle the the type accordingly in wasm_c_api.c and wasm_runtime_common.c, and fix a typo in V128 union.	2024-05-14 10:22:42 +08:00
YAMAMOTO Takashi	456e2f6919	aot compiler: Fix a type mismatch in compile_op_float_min_max (#3423) ... Fixes https://github.com/bytecodealliance/wasm-micro-runtime/issues/3422	2024-05-14 10:06:48 +08:00
YAMAMOTO Takashi	8f098a5905	aot: Make precheck functions use short-call for xtensa (#3418) ... Note: this breaks AOT ABI for xtensa again because of a revert of an ABI-breaking change.	2024-05-13 16:55:00 +08:00