408 Commits

Author	SHA1	Message	Date
Jan Olaf Martin	59f761b58d	aot compiler: Track non-0x00 tableindex as ref types use (#3695) ... Any use of a table index that isn't exactly a null byte (`0x00`) means that the module makes use of the reference types proposal. This is important to track because `aot_compiler.c` will blindly assume that all table indices are a single byte long otherwise. This fixes a crash in WAMR for modules that contain multi-byte encodings of table indices in `call_indirect` but make no other use of reference types features.	2024-08-16 12:37:10 +08:00
Wenyong Huang	da25906ed4	debug-interp: Only add lock when signal_flag is SIG_SINGSTEP (#3704) ... As reported in #3500, when debug interpreter is enabled, the classic interpreter performs a lock operation to read `exec_env->current_status->signal_flag` and do further handling before fetching next opcode, which makes the interpreter run slower. This PR atomic loads the `exec_env->current_status->signal_flag` without mutex lock when 32-bit atomic load is supported, and only adding lock for further handling when the signal_flag is WAMR_SIG_SINGSTEP, which improves the performance.	2024-08-14 09:03:01 +08:00
Marcin Kolny	37d7439ef9	[refactoring] Extract read leb to a separate file, share the code between loader and mini loader (#3701) ... There's probably a number of other places where the bh_leb_read could be used (e.g. aot loader) but I'm making the change as small as possible. Further refactoring can be done later.	2024-08-14 08:46:24 +08:00
YAMAMOTO Takashi	50f28495a1	Remove a few hardcoded spec test knowledge from the core library (#3648) ... Tweak the stack sizes in the spec test runner instead.	2024-07-22 13:30:00 +08:00
Benbuck Nason	501d7d5adf	Add apis to get package version (#3601) ... Add three APIs: - wasm_runtime_get_file_package_version - wasm_runtime_get_module_package_version - wasm_runtime_get_current_package_version	2024-07-16 08:15:59 +08:00
Wenyong Huang	73caf19e69	Fix compile warnings/error reported in Windows (#3616) ... Clear some compile warnings and fix undefined reference error for symbol ffs in Windows platform.	2024-07-12 16:43:22 +08:00
YAMAMOTO Takashi	46695b992c	EH: Use the consistent type for EH handlers (#3619) ... The "handlers" on the interpreter stack is sometimes treated as host pointers and sometimes treated as i64 values. It's quite broken for targets where pointers are not 64-bit. This commit makes them host pointers consistently. (at least for 32-bit and 64-bit pointers. We don't support other pointer sizes anyway.) Fixes https://github.com/bytecodealliance/wasm-micro-runtime/issues/3110	2024-07-12 11:00:55 +08:00
YAMAMOTO Takashi	1b1ec715e9	wasm loader: Reject v128 for interpreters (#3611) ... discussed in: https://github.com/bytecodealliance/wasm-micro-runtime/pull/3592	2024-07-10 13:50:52 +08:00
Benbuck Nason	8aba85825c	Avoid redefining WASMMemoryType (#3602)	2024-07-10 10:05:47 +08:00
Wenyong Huang	0feae05379	wasm loader: Fix several issues in GC and exception handling (#3586) ... Fix several issues of GC and exception handling in wasm loader: - Should restore param_reftype_maps/param_reftype_map_count/param_count in the handling of opcode throw - Should set wasm_ref_type when pushing param types of tag type and block type if the type is a multi-byte type - Should set init_values.data as NULL for opcode struct.new_default in load_init_expr This PR fixes the issues reported in #3411.	2024-07-05 19:15:58 +08:00
Wenyong Huang	1f94cd4ee5	wasm loader: Fix push_frame_offset when pushing v128 type (#3588) ... Fixes issue https://github.com/bytecodealliance/wasm-micro-runtime/issues/3580.	2024-07-03 15:18:42 +08:00
liang.he	f118492b1d	Add integer overflow check for some indices in wasm/aot loader (#3579) ... Check whether the indices overflow UINT32_MAX or not for: - import function count + function count - import global count + global count - import tag count + tag count This PR fixes the issue reported by Oss-fuzz test (#69920).	2024-07-02 15:48:37 +08:00
TianlongLiang	a5753ea920	interp debugger: Fix setting invalid value to step_count (#3583) ... The `exec_env->current_status->step_count` should be set same as the handling when WASM_ENABLE_LABELS_AS_VALUES is not 0. Fixes issue https://github.com/bytecodealliance/wasm-micro-runtime/issues/3475.	2024-07-02 11:03:49 +08:00
Xenia Lu	f7d2826772	Allow missing imports in wasm loader and report error in wasm instantiation instead (#3539) ... The wasm loader is failing when multi-module support is on and the dependent modules are not found; this enforces the AOT compiler integrations to prepare dependent modules while it isn't necessary. This PR allows allows missing imports in wasm loader and report error in wasm instantiation instead, which enables the integrated AOT compiler to work as if the multi-module support isn't turned on.	2024-06-25 10:04:39 +08:00
Wenyong Huang	9b9e938bee	Fix compilation errors (#3549) ... The compilation errors were introduced by #3515 and occur in debug building when wasm mini loader is compiled or GC is enabled. And remove two wasm files in standalone test-running-modes case, which will be generated by run.sh.	2024-06-20 12:33:52 +08:00
Benbuck Nason	3746534010	Add table type API support (#3515) ... Add `wasm_runtime_get_export_table_inst` and `wasm_table_get_func_inst`, and related wasm_table_type_get_xxx APIs.	2024-06-19 14:50:46 +08:00
liang.he	c19bc95391	Validate func type in aot loader (#3535) ... Fix issue reported by Oss-fuzz test (#69629).	2024-06-18 14:23:32 +08:00
Wenyong Huang	d3e89895be	wasm loader: Fix pop invalid offset count when stack top is ANY (#3516) ... In wasm_loader_pop_frame_offset, when the stack is in polymorphic state and the stack top operand is VALUE_TYPE_ANY, if we popping I64/F64 operand, we should pop one offset but not two offsets. The issue was reported in #3513 and #3514.	2024-06-14 16:22:08 +08:00
liang.he	f844b33b2d	Make wasi-nn backends as separated shared libraries (#3509) ... - All files under *core/iwasm/libraries/wasi-nn* are compiled as shared libraries - *wasi-nn.c* is shared between backends - Every backend has a separated shared library - If wasi-nn feature is enabled, iwasm will depend on shared library libiwasm.so instead of linking static library libvmlib.a	2024-06-14 12:06:56 +08:00
liang.he	40c41d5110	Fix several issues reported by oss-fuzz (#3526) ... - possible integer overflow in adjust_table_max_size: unsigned integer overflow: 2684354559 * 2 cannot be represented in type 'uint32' - limit max memory size in wasm_runtime_malloc - add more checks in aot loader - adjust compilation options	2024-06-13 16:06:36 +08:00
liang.he	028f43bc18	Fix compilation warnings of wasi-nn (#3497)	2024-06-07 10:49:44 +08:00
Benbuck Nason	5d1f19fc09	Fix wasm_mini_loader.c build when jit or multi-module is enabled (#3502) ... This PR fixes compilation error when building with `-DWAMR_BUILD_MINI_LOADER=1 -DWAMR_BUILD_JIT=1` or `-DWAMR_BUILD_MINI_LOADER=1 -DWAMR_BUILD_MULTI_MODULE=1`, though normally we don't use wasm mini loader when JIT or multi-module is enabled.	2024-06-06 09:53:22 +08:00
Benbuck Nason	8239dd4aa7	Add wasm_export.h APIs to expose memory type (#3496) ... Support to get `wasm_memory_type_t memory_type` from API `wasm_runtime_get_import_type` and `wasm_runtime_get_export_type`, and then get shared flag, initial page cout, maximum page count from the memory_type: ```C bool wasm_memory_type_get_shared(const wasm_memory_type_t memory_type); uint32_t wasm_memory_type_get_init_page_count(const wasm_memory_type_t memory_type); uint32_t wasm_memory_type_get_max_page_count(const wasm_memory_type_t memory_type); ```	2024-06-06 09:20:24 +08:00
Wenyong Huang	0a80cc4e94	Fix wasm loader check data segment count (#3492) ... When datacount section exists, loader will check whether the data count read from data segment section is same with the data count read from datacount section, but the value of latter can be 0, loader should not skip the check when the latter is 0. This fixes #3491. And fix handle_name_section return value not checked issue and early return true issue after handle_name_section. And also add the failed case in #3491 to ba-issues.	2024-06-03 19:48:11 +08:00
Wenyong Huang	23e1d51587	Fix loader parse block type and calculate dynamic offset for loop args (#3482) ... Fix several issues in wasm loader: - Parse a block's type index with leb int32 instead leb uint32 - Correct dst dynamic offset of loop block arguments for opcode br when copying the stack operands to the arguments of loop block - Free each frame_csp's param_frame_offsets when destroy loader ctx - Fix compilation error in wasm_mini_loader.c - Add test cases of failed issues This PR fixes issue #3467 and #3468.	2024-05-31 11:32:36 +08:00
Wenyong Huang	5623e4d22a	Fix memory64 handling find_block_addr and execute_main (#3480)	2024-05-30 16:14:12 +08:00
liang.he	d29802c451	Fix two issues to make fuzzing test quit earlier (#3471) ... - Add a marco to limit the maxi allocable memory size of fuzz test to 2GB to avoid libFuzzer out-of-memory - Check global type in load_global_import and load_global_section	2024-05-30 14:55:21 +08:00
Enrico Loparco	3b8ef89110	Clone data segments when specified with load args (#3463) ... Follow-up on https://github.com/bytecodealliance/wasm-micro-runtime/pull/3389, specifically: https://github.com/bytecodealliance/wasm-micro-runtime/pull/3389#discussion_r1600872451 If we want to free the wasm binary buffer early, we need to clone the data segments into the module. That's because, in case of [passive data segments](https://webassembly.github.io/threads/core/syntax/modules.html#syntax-data), they can be referred during wasm execution.	2024-05-27 09:59:24 +08:00
Wenyong Huang	6fdfedb08a	Fix codeql compilation error (#3461) ... Update OS to ubuntu-22.04 and install `libgcc-12-dev lib32gcc-12-dev` instead of `libgcc-11-dev lib32gcc-11-dev`. And fix a bh_assert condition typo error. ps. https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/9183310069/job/25253782329	2024-05-22 17:27:38 +08:00
Wenyong Huang	15d191943a	Enhance GC const initializer expression to support nested struct/array new (#3447) ... Only support interpreter now, and fix some issues found in wasm loader. This PR fixes issue #3410 and #3411.	2024-05-21 16:09:12 +08:00
TianlongLiang	30ed97cddc	Fix several typos and fix bh_log calculate mills (#3441)	2024-05-20 15:54:01 +08:00
liang.he	b2eb7d838d	Update spec test to latest commit (#3293) ... - Update spec test cases to commit bc76fd79cfe61033d7f4ad4a7e8fc4f996dc5ba8 on Apr. 3 - Update wabt binary to 1.0.34 to support newer spec cases - Add comparison between table declared elem type and table elem segment value type - Add a function to decide whether to execute test cases in a running mode - Keep using interpreter in GC spec because wat2wasm in wabt can't compile if.wast w/o errors - Re-factoring threads spec test case processing - Since wabt 1.0.34 release isn't compatible with ubuntu 20.04, compile it from source code - Disable CI to run aot multi-module temporarily, and will enable it in another PR	2024-05-17 10:40:47 +08:00
Enrico Loparco	6b1d81650d	Allow not copying the wasm binary in wasm-c-api and not referring to the binary in wasm/aot loader (#3389) ... Add flag `LoadArgs.clone_wasm_binary` to control whether to clone the wasm/aot binary in wasm-c-api module. If false, API `wasm_module_new_ex` won't clone the binary, which may reduce the footprint. Add flag `LoadArgs.wasm_binary_freeable` to control whether the wasm/aot binary may be freed after instantiation for wamr API `wasm_runtime_load_ex`, if yes, then for some running modes, the wasm/aot module doesn't refer to the input binary again so developer can free it after instantiation to reduce the footprint. And add API `wasm_module_is_underlying_binary_freeable` and `wasm_runtime_is_underlying_binary_freeable` to check whether the input binary can be freed after instantiation for wasm-c-api and wamr api. And add sample to illustrate it.	2024-05-17 09:00:08 +08:00
Wenyong Huang	7949df96f4	Fix fast interp RECOVER_BR_INFO and local set/tee (#3434) ... When copying two cells from src offsets to dst offsets in RECOVER_BR_INFO, the offsets may be overlapped and the src data may be overwritten, use GET_I64_FROM_ADDR and then SET_I64_FROM_ADDR instead to resolve it. And handling VALUE_TYPE_FUNCREF/VALUE_TYPE_EXTERNREF for opcode local.set and local.tee when reference types feature is enabled. This PR fixes issue #3401 and #3402.	2024-05-15 15:20:21 +08:00
Wenyong Huang	49c9fa31da	Fix typo of WAMR_CONFIGUABLE_BOUNDS_CHECKS (#3424) ... Change to WAMR_CONFIGURABLE_BOUNDS_CHECKS, and fix CodeQL compilation errors which were introduced by PR #3406. ps. https://github.com/bytecodealliance/wasm-micro-runtime/pull/3393#discussion_r1591810998 https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/9055318553/job/24876266629	2024-05-14 14:33:09 +08:00
Benbuck Nason	dbd8790681	Add WASM_V128 in wasm_valkind_enum (#3412) ... Add WASM_V128 in wasm_valkind_enum and handle the the type accordingly in wasm_c_api.c and wasm_runtime_common.c, and fix a typo in V128 union.	2024-05-14 10:22:42 +08:00
TianlongLiang	c6d42db598	Correct Exception Handling tag type when GC is enabled (#3413) ... Use `WASMFuncType` to represent tag_type in `WASMTagImport` and `WASMTag` so that the type definition is consistent no matter to GC is enabled or not. This PR fixes https://github.com/bytecodealliance/wasm-micro-runtime/issues/3409.	2024-05-13 16:42:01 +08:00
Marcin Kolny	fe5e7a9981	Implement Memory64 support for AOT (#3362) ... Refer to: https://github.com/bytecodealliance/wasm-micro-runtime/pull/3266 https://github.com/bytecodealliance/wasm-micro-runtime/issues/3091	2024-05-13 11:03:38 +08:00
Benbuck Nason	c85bada2a9	Add wasm module global type information APIs (#3406) ... Support getting global type from `wasm_runtime_get_import_type` and `wasm_runtime_get_export_type`, and add two APIs: ```C wasm_valkind_t wasm_global_type_get_valkind(const wasm_global_type_t global_type); bool wasm_global_type_get_mutable(const wasm_global_type_t global_type); ```	2024-05-10 09:15:58 +08:00
Wenyong Huang	a6c0cb74c9	wasm loader: Fix handling if block without op else (#3404) ... If there is no else branch, make a virtual else opcode for easier integrity check and to copy the correct results to the block return address for fast-interp mode: change if block from `if ... end` to `if ... else end`. Reported in issue #3386, #3387, #3388.	2024-05-09 16:46:26 +08:00
TianlongLiang	ea13d47a41	ref-types: Correct default value for function local variables (#3397) ... In classic interpreter, fast interpreter and fast-jit running modes, set the local variables' default value to NULL_REF (0xFFFFFFFF) rather than 0 if they are type of externref or funcref. The issue was reported in #3390 and #3391.	2024-05-09 16:31:21 +08:00
Benbuck Nason	432a940735	Fix clang compile warnings (#3396)	2024-05-08 16:43:47 +08:00
Benbuck Nason	1c2a8fca4e	Fix some more spelling issues (#3393)	2024-05-08 09:30:29 +08:00
Benbuck Nason	ca61184ced	Fix some spelling issues (#3385) ... Fix some of the spelling issues found by CSpell.	2024-05-06 07:56:48 +08:00
TianlongLiang	79ae910a7c	Fix loader and mini-loader select potiential error (#3374) ... Fix the issue reported in https://github.com/bytecodealliance/wasm-micro-runtime/issues/3361.	2024-04-29 12:27:55 +08:00
Wenyong Huang	e11eae93e2	Fix aot debugger compilation error on windows (#3370) ... Fix aot debugger compilation error on windows as reported in #3184. And update the stack size configuration for product-mini zephyr sample since the native stack overflow check was enhanced and the zephyr-sdk was also upgraded.	2024-04-29 10:38:43 +08:00
YAMAMOTO Takashi	410ee580ae	Add wasm_runtime_detect_native_stack_overflow_size (#3355) ... - Add a few API (https://github.com/bytecodealliance/wasm-micro-runtime/issues/3325) ```c wasm_runtime_detect_native_stack_overflow_size wasm_runtime_detect_native_stack_overflow ``` - Adapt the runtime to use them - Adapt samples/native-stack-overflow to use them - Add a few missing overflow checks in the interpreters - Build and run the sample on the CI	2024-04-26 16:00:58 +08:00
Wenyong Huang	e44465d259	Enhance wasm loader checks for opcode br_table (#3352) ... Fix the integer overflow issue when checking target branch depth in opcode br_table, and fix is_32bit_type not check VALUE_TYPE_ANY issue, which may cause wasm_loader_push_frame_offset push extra unneeded offset.	2024-04-25 20:07:57 +08:00
YAMAMOTO Takashi	9d6d3466ff	Fix a few native stack address calculations (#3351)	2024-04-24 16:39:38 +08:00
Wenyong Huang	18d363029c	wasm loader: Fix checks for opcode ref.func and opcode else (#3340) ... Fix wasm loader integrity checks for opcode ref.func and opcode else: for opcode ref.func, the function must be an import, exported, or present in a table elem segment or global initializer to be used as the operand to ref.func, for opcode else, there must not be an else opcode previously. Reported in #3336 and #3337. And fix mini loader PUSH_MEM_OFFSET/POP_MEM_OFFSET macro definitions due to the introducing of memory64 feature.	2024-04-22 14:44:45 +08:00