wasm-micro-runtime

gnh1201/wasm-micro-runtime

Fork 0

mirror of https://github.com/bytecodealliance/wasm-micro-runtime.git synced 2024-11-26 15:32:05 +00:00

Commit Graph

Author	SHA1	Message	Date
Marcin Kolny	72b34eaf30	Fix AOT shift operations for indirect constants (#2627 ) When doing more investigations related to this PR: https://github.com/bytecodealliance/wasm-micro-runtime/pull/2619 We found that in some scenarios the constant might not be directly available to the LLVM IR builder, e.g.: ``` (func $const_ret (result i32) i32.const -5 ) (func $foo (i32.shr_u (i32.const -1) (call $const_ret)) (i32.const 31) ) ``` In that case, the right parameter to `i32.shr_u` is not constant, therefore the `SHIFT_COUNT_MASK` isn't applied. However, when the optimization is enabled (`--opt-level` is 2 or 3), the optimization passes resolve the call into constant, and that constant is poisoned, causing the compiler to resolve the whole function to an exception.	2023-10-11 11:22:34 +08:00
Marcin Kolny	b115b7baac	Fix compilation of shift opcodes on x86_64 and i386 architectures (#2619 ) This change fixes the case where the right parameter of shift operator is negative, specifically, when both parameters of shift opcode are constants.	2023-10-07 19:55:14 +08:00

Author

SHA1

Message

Date

Marcin Kolny

72b34eaf30

Fix AOT shift operations for indirect constants (#2627 )

When doing more investigations related to this PR:
  https://github.com/bytecodealliance/wasm-micro-runtime/pull/2619
We found that in some scenarios the constant might not be directly
available to the LLVM IR builder, e.g.:
```
  (func $const_ret (result i32)
    i32.const -5
  )
  (func $foo
    (i32.shr_u (i32.const -1) (call $const_ret))
    (i32.const 31)
  )
```
In that case, the right parameter to `i32.shr_u` is not constant, therefore
the `SHIFT_COUNT_MASK` isn't applied. However, when the optimization
is enabled (`--opt-level` is 2 or 3), the optimization passes resolve the
call into constant, and that constant is poisoned, causing the compiler to
resolve the whole function to an exception.

2023-10-11 11:22:34 +08:00

Marcin Kolny

b115b7baac

Fix compilation of shift opcodes on x86_64 and i386 architectures (#2619 )

This change fixes the case where the right parameter of shift
operator is negative, specifically, when both parameters of
shift opcode are constants.

2023-10-07 19:55:14 +08:00

2 Commits