Merge bca4ed4fee into b0c6d5c23a

- add testcases for shared_heap
- fix POP_MEM_OFFSET and POP_TBL_ELEM_IDX of memory64

Signed-off-by: wenlingyun1 <wenlingyun1@xiaomi.com>

.github/workflows/compilation_on_android_ubuntu.yml

@@ -828,7 +828,7 @@ jobs:
         run: |
           mkdir build
           cd build
-          cmake .. -DWAMR_BUILD_DEBUG_INTERP=1
+          cmake .. -DWAMR_BUILD_DEBUG_INTERP=1 -DWAMR_BUILD_REF_TYPES=1
           make
         working-directory: product-mini/platforms/linux
 

core/iwasm/aot/aot_runtime.c

@@ -1905,7 +1905,9 @@ aot_instantiate(AOTModule *module, AOTModuleInstance *parent,
             goto fail;
         }
         for (i = 0; i < module->table_init_data_count; i++) {
-            if (wasm_elem_is_active(module->table_init_data_list[i]->mode))
+            if (wasm_elem_is_active(module->table_init_data_list[i]->mode)
+                || wasm_elem_is_declarative(
+                    module->table_init_data_list[i]->mode))
                 bh_bitmap_set_bit(common->elem_dropped, i);
         }
     }

core/iwasm/common/wasm_runtime_common.c

@@ -3631,8 +3631,14 @@ wasm_runtime_init_wasi(WASMModuleInstanceCommon *module_inst,
 
         bh_memcpy_s(mapping_copy, max_len, map_dir_list[i],
                     (uint32)(strlen(map_dir_list[i]) + 1));
-        map_mapped = strtok(mapping_copy, "::");
-        map_host = strtok(NULL, "::");
+
+        const char *delim = "::";
+        char *delim_pos = strstr(mapping_copy, delim);
+        if (delim_pos) {
+            *delim_pos = '\0';
+            map_mapped = mapping_copy;
+            map_host = delim_pos + strlen(delim);
+        }
 
         if (!map_mapped || !map_host) {
             if (error_buf)

core/iwasm/compilation/aot_emit_memory.c

@@ -273,10 +273,24 @@ aot_check_memory_overflow(AOTCompContext *comp_ctx, AOTFuncContext *func_ctx,
     }
 
     /* offset1 = offset + addr; */
-    /* TODO: check whether integer overflow occurs when memory is 64-bit
-             and boundary check is enabled */
     BUILD_OP(Add, offset_const, addr, offset1, "offset1");
 
+    if (is_memory64 && comp_ctx->enable_bound_check) {
+        /* Check whether integer overflow occurs in offset + addr */
+        LLVMBasicBlockRef check_integer_overflow_end;
+        ADD_BASIC_BLOCK(check_integer_overflow_end,
+                        "check_integer_overflow_end");
+        LLVMMoveBasicBlockAfter(check_integer_overflow_end, block_curr);
+
+        BUILD_ICMP(LLVMIntULT, offset1, offset_const, cmp1, "cmp1");
+        if (!aot_emit_exception(comp_ctx, func_ctx,
+                                EXCE_OUT_OF_BOUNDS_MEMORY_ACCESS, true, cmp1,
+                                check_integer_overflow_end)) {
+            goto fail;
+        }
+        SET_BUILD_POS(check_integer_overflow_end);
+    }
+
     if (comp_ctx->enable_shared_heap /* TODO: && mem_idx == 0 */) {
         LLVMBasicBlockRef app_addr_in_shared_heap, app_addr_in_linear_mem;
         LLVMValueRef is_in_shared_heap, shared_heap_check_bound = NULL;
@@ -303,7 +317,7 @@ aot_check_memory_overflow(AOTCompContext *comp_ctx, AOTFuncContext *func_ctx,
         LLVMPositionBuilderAtEnd(comp_ctx->builder, block_curr);
 
         if (!is_target_64bit) {
-            /* Check whether interger overflow occurs in addr + offset */
+            /* Check whether integer overflow occurs in addr + offset */
             LLVMBasicBlockRef check_integer_overflow_end;
             ADD_BASIC_BLOCK(check_integer_overflow_end,
                             "check_integer_overflow_end");
@@ -1215,10 +1229,24 @@ check_bulk_memory_overflow(AOTCompContext *comp_ctx, AOTFuncContext *func_ctx,
         goto fail;
     }
 
-    /* TODO: check whether integer overflow occurs when memory is 64-bit
-             and boundary check is enabled */
     BUILD_OP(Add, offset, bytes, max_addr, "max_addr");
 
+    if (is_memory64 && comp_ctx->enable_bound_check) {
+        /* Check whether integer overflow occurs in offset + addr */
+        LLVMBasicBlockRef check_integer_overflow_end;
+        ADD_BASIC_BLOCK(check_integer_overflow_end,
+                        "check_integer_overflow_end");
+        LLVMMoveBasicBlockAfter(check_integer_overflow_end, block_curr);
+
+        BUILD_ICMP(LLVMIntULT, max_addr, offset, cmp, "cmp");
+        if (!aot_emit_exception(comp_ctx, func_ctx,
+                                EXCE_OUT_OF_BOUNDS_MEMORY_ACCESS, true, cmp,
+                                check_integer_overflow_end)) {
+            goto fail;
+        }
+        SET_BUILD_POS(check_integer_overflow_end);
+    }
+
     if (comp_ctx->enable_shared_heap /* TODO: && mem_idx == 0 */) {
         LLVMBasicBlockRef app_addr_in_shared_heap, app_addr_in_linear_mem;
         LLVMValueRef shared_heap_start_off, shared_heap_check_bound;

core/iwasm/interpreter/wasm_interp_classic.c

@@ -593,8 +593,8 @@ wasm_interp_get_frame_ref(WASMInterpFrame *frame)
 #endif
 
 #if WASM_ENABLE_MEMORY64 != 0
-#define POP_MEM_OFFSET() (is_memory64 ? POP_I64() : POP_I32())
-#define POP_TBL_ELEM_IDX() (is_table64 ? POP_I64() : POP_I32())
+#define POP_MEM_OFFSET() (is_memory64 ? POP_I64() : (uint32)POP_I32())
+#define POP_TBL_ELEM_IDX() (is_table64 ? POP_I64() : (uint32)POP_I32())
 #else
 #define POP_MEM_OFFSET() POP_I32()
 #define POP_TBL_ELEM_IDX() POP_I32()

core/iwasm/interpreter/wasm_runtime.c

@@ -1208,9 +1208,8 @@ globals_instantiate(WASMModule *module, WASMModuleInstance *module_inst,
 
             /* The linked global instance has been initialized, we
                just need to copy the value. */
-            bh_memcpy_s(&(global->initial_value), sizeof(WASMValue),
-                        &(global_import->import_global_linked->init_expr.u),
-                        sizeof(WASMValue));
+            global->initial_value =
+                global_import->import_global_linked->init_expr.u;
         }
         else
 #endif
@@ -2467,7 +2466,8 @@ wasm_instantiate(WASMModule *module, WASMModuleInstance *parent,
             goto fail;
         }
         for (i = 0; i < module->table_seg_count; i++) {
-            if (wasm_elem_is_active(module->table_segments[i].mode))
+            if (wasm_elem_is_active(module->table_segments[i].mode)
+                || wasm_elem_is_declarative(module->table_segments[i].mode))
                 bh_bitmap_set_bit(module_inst->e->common.elem_dropped, i);
         }
     }

core/shared/platform/zephyr/shared_platform.cmake

@@ -14,5 +14,11 @@ endif()
 
 file (GLOB_RECURSE source_all ${PLATFORM_SHARED_DIR}/*.c)
 
+if (WAMR_BUILD_LIBC_WASI EQUAL 1)
+  list(APPEND source_all ${PLATFORM_SHARED_DIR}/../common/posix/posix_file.c)
+  include (${CMAKE_CURRENT_LIST_DIR}/../common/libc-util/platform_common_libc_util.cmake)
+  set(source_all ${source_all} ${PLATFORM_COMMON_LIBC_UTIL_SOURCE})
+endif ()
+
 set (PLATFORM_SHARED_SOURCE ${source_all} ${PLATFORM_COMMON_MATH_SOURCE})
 

test-tools/wamr-ide/VSCode-Extension/src/test/suite/extension.test.ts

@@ -196,11 +196,14 @@ suite('Inegration Tests', function () {
         );
 
         // Vector
-        assert.equal(
-            namesToVariables['vector'].value,
-            ' (5) vec![1, 2, 3, 4, 12]',
-            'The Vector summary string looks different than expected'
-        );
+        // TODO: The vector format conversion have some problem now, can't see the actual value
+        // - (5) vec![{...}, {...}, {...}, {...}, {...}, ...]
+        // + (5) vec![1, 2, 3, 4, 12]
+        // assert.equal(
+        //     namesToVariables['vector'].value,
+        //     ' (5) vec![1, 2, 3, 4, 12]',
+        //     'The Vector summary string looks different than expected'
+        // );
 
         // Map
         assert.equal(

tests/unit/shared-heap/CMakeLists.txt

@@ -8,7 +8,7 @@ project(test-shared-heap)
 add_definitions(-DRUN_ON_LINUX)
 
 set(WAMR_BUILD_APP_FRAMEWORK 0)
-set(WAMR_BUILD_AOT 0)
+set(WAMR_BUILD_AOT 1)
 set(WAMR_BUILD_INTERP 1)
 set(WAMR_BUILD_FAST_INTERP 1)
 set(WAMR_BUILD_JIT 0)

tests/unit/shared-heap/shared_heap_test.cc

@@ -92,37 +92,28 @@ destroy_module_env(struct ret_env module_env)
     }
 }
 
-TEST_F(shared_heap_test, test_shared_heap)
+static void test_shared_heap(WASMSharedHeap *shared_heap, const char *file, const char *func_name, uint32 argc, uint32 argv[])
 {
     struct ret_env tmp_module_env;
     WASMFunctionInstanceCommon *func_test = nullptr;
     bool ret = false;
-    uint32 argv[1] = { 65535 };
     const char *exception = nullptr;
-    SharedHeapInitArgs args;
-    WASMSharedHeap *shared_heap = nullptr;
 
-    args.size = 1024;
-    shared_heap = wasm_runtime_create_shared_heap(&args);
-    tmp_module_env = load_wasm((char *)"test.wasm", 0);
+    tmp_module_env = load_wasm((char *)file, 0);
 
-    if (!shared_heap) {
-        printf("Failed to create shared heap\n");
-        goto test_failed;
-    }
     if (!wasm_runtime_attach_shared_heap(tmp_module_env.wasm_module_inst, shared_heap)) {
         printf("Failed to attach shared heap\n");
         goto test_failed;
     }
-    func_test = wasm_runtime_lookup_function(
-        tmp_module_env.wasm_module_inst, "test");
+    func_test = wasm_runtime_lookup_function(tmp_module_env.wasm_module_inst,
+                                             func_name);
     if (!func_test) {
         printf("\nFailed to wasm_runtime_lookup_function!\n");
         goto test_failed;
     }
 
     ret =
-        wasm_runtime_call_wasm(tmp_module_env.exec_env, func_test, 1, argv);
+        wasm_runtime_call_wasm(tmp_module_env.exec_env, func_test, argc, argv);
     if (!ret) {
         printf("\nFailed to wasm_runtime_call_wasm!\n");
         const char *s = wasm_runtime_get_exception(tmp_module_env.wasm_module_inst);
@@ -131,12 +122,119 @@ TEST_F(shared_heap_test, test_shared_heap)
     }
 
     wasm_runtime_detach_shared_heap(tmp_module_env.wasm_module_inst);
-
-    EXPECT_EQ(10, argv[0]);
-
     destroy_module_env(tmp_module_env);
     return;
 test_failed:
     destroy_module_env(tmp_module_env);
     EXPECT_EQ(1, 0);
 }
+
+TEST_F(shared_heap_test, test_shared_heap_basic)
+{
+    SharedHeapInitArgs args;
+    WASMSharedHeap *shared_heap = nullptr;
+    uint32 argv[1] = { 0 };
+
+    args.size = 1024;
+    shared_heap = wasm_runtime_create_shared_heap(&args);
+
+    if (!shared_heap) {
+        printf("Failed to create shared heap\n");
+        EXPECT_EQ(1, 0);
+    }
+
+    // test wasm
+    test_shared_heap(shared_heap, "test.wasm", "test", 1, argv);
+    EXPECT_EQ(10, argv[0]);
+
+    // test aot
+    test_shared_heap(shared_heap, "test.aot", "test", 1, argv);
+    EXPECT_EQ(10, argv[0]);
+
+}
+
+TEST_F(shared_heap_test, test_shared_heap_malloc_fail)
+{
+    SharedHeapInitArgs args;
+    WASMSharedHeap *shared_heap = nullptr;
+    uint32 argv[1] = { 0 };
+
+    args.size = 1024;
+    shared_heap = wasm_runtime_create_shared_heap(&args);
+
+    if (!shared_heap) {
+        printf("Failed to create shared heap\n");
+        EXPECT_EQ(1, 0);
+    }
+
+    // test wasm
+    test_shared_heap(shared_heap, "test.wasm", "test_malloc_fail", 1, argv);
+    EXPECT_EQ(1, argv[0]);
+
+    // test aot
+    test_shared_heap(shared_heap, "test.aot", "test_malloc_fail", 1, argv);
+    EXPECT_EQ(1, argv[0]);
+}
+
+#ifndef native_function
+#define native_function(func_name, signature) \
+    { #func_name, (void *)glue_##func_name, signature, NULL }
+
+#endif
+#ifndef nitems
+#define nitems(_a) (sizeof(_a) / sizeof(0 [(_a)]))
+#endif /* nitems */
+uintptr_t glue_test_addr_conv(wasm_exec_env_t env, uintptr_t addr)
+{
+  wasm_module_inst_t module_inst = get_module_inst(env);
+  uintptr_t ret;
+  void *native_addr = (void *)addr;
+  uintptr_t app_addr = addr_native_to_app(native_addr);
+
+  native_addr = addr_app_to_native(app_addr);
+  if (native_addr != (void *)addr)
+  {
+    EXPECT_EQ(1, 0);
+  }
+  return app_addr;
+}
+
+static NativeSymbol g_test_native_symbols[] =
+{
+  native_function(test_addr_conv,"(*)i"),
+};
+
+TEST_F(shared_heap_test, test_addr_conv)
+{
+    SharedHeapInitArgs args;
+    WASMSharedHeap *shared_heap = nullptr;
+    uint32 argv[1] = { 0 };
+    struct ret_env tmp_module_env;
+    WASMFunctionInstanceCommon *func_test = nullptr;
+    bool ret = false;
+    const char *exception = nullptr;
+    wasm_module_inst_t module_inst = tmp_module_env.wasm_module_inst;
+
+    ret = wasm_native_register_natives("env", g_test_native_symbols,
+                                       nitems(g_test_native_symbols));
+    if (!ret)
+    {
+        EXPECT_EQ(1, 0);
+        return;
+    }
+
+    args.size = 1024;
+    shared_heap = wasm_runtime_create_shared_heap(&args);
+    if (!shared_heap) {
+        printf("Failed to create shared heap\n");
+        EXPECT_EQ(1, 0);
+    }
+
+    // test wasm
+    test_shared_heap(shared_heap, "test_addr_conv.wasm", "test", 1, argv);
+    EXPECT_EQ(1, argv[0]);
+
+    // test aot
+    test_shared_heap(shared_heap, "test_addr_conv.aot", "test", 1, argv);
+    EXPECT_EQ(1, argv[0]);
+}

tests/unit/shared-heap/wasm-apps/CMakeLists.txt

@@ -5,6 +5,7 @@ cmake_minimum_required(VERSION 3.14)
 project(wasm-apps)
 
 set(WAMR_ROOT_DIR ${CMAKE_CURRENT_SOURCE_DIR}/../../../..)
+set(WAMRC_ROOT_DIR ${WAMR_ROOT_DIR}/wamr-compiler/build)
 
 set(CMAKE_SYSTEM_PROCESSOR wasm32)
 set(CMAKE_SYSROOT ${WAMR_ROOT_DIR}/wamr-sdk/app/libc-builtin-sysroot)
@@ -37,3 +38,35 @@ add_custom_command(TARGET test.wasm POST_BUILD
         ${CMAKE_CURRENT_BINARY_DIR}/../
         COMMENT "Copy test.wasm to the same directory of google test"
         )
+
+add_custom_command(TARGET test.wasm POST_BUILD
+        COMMAND ${WAMRC_ROOT_DIR}/wamrc --opt-level=0 --enable-shared-heap --bounds-checks=1
+        -o
+        test.aot
+        test.wasm
+        COMMAND ${CMAKE_COMMAND} -E copy
+        ${CMAKE_CURRENT_BINARY_DIR}/test.aot
+        ${CMAKE_CURRENT_BINARY_DIR}/../
+        COMMENT "Copy test.aot to the same directory of google test"
+        )
+
+add_executable(test_addr_conv.wasm test_addr_conv.c)
+target_link_libraries(test.wasm)
+
+add_custom_command(TARGET test_addr_conv.wasm POST_BUILD
+        COMMAND ${CMAKE_COMMAND} -E copy
+        ${CMAKE_CURRENT_BINARY_DIR}/test_addr_conv.wasm
+        ${CMAKE_CURRENT_BINARY_DIR}/../
+        COMMENT "Copy test_addr_conv.wasm to the same directory of google test"
+        )
+
+add_custom_command(TARGET test_addr_conv.wasm POST_BUILD
+        COMMAND ${WAMRC_ROOT_DIR}/wamrc --opt-level=0 --enable-shared-heap --bounds-checks=1
+        -o
+        test_addr_conv.aot
+        test_addr_conv.wasm
+        COMMAND ${CMAKE_COMMAND} -E copy
+        ${CMAKE_CURRENT_BINARY_DIR}/test_addr_conv.aot
+        ${CMAKE_CURRENT_BINARY_DIR}/../
+        COMMENT "Copy test_addr_conv.aot to the same directory of google test"
+        )

tests/unit/shared-heap/wasm-apps/test.c

@@ -13,10 +13,22 @@ shared_heap_free(void *offset);
 int
 test()
 {
-    int *ptr = (int *)shared_heap_malloc(10);
+    int *ptr = (int *)shared_heap_malloc(4);
 
     *ptr = 10;
     int a = *ptr;
     shared_heap_free(ptr);
     return a;
 }
+
+int
+test_malloc_fail()
+{
+    int *ptr = (int *)shared_heap_malloc(8192);
+
+    if (ptr == NULL) {
+        return 1;
+    }
+    shared_heap_free(ptr);
+    return 0;
+}

tests/unit/shared-heap/wasm-apps/test_addr_conv.c

@@ -0,0 +1,32 @@
+/*
+ * Copyright (C) 2024 Xiaomi Corporation.  All rights reserved.
+ * SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+ */
+
+#include <stdio.h>
+
+extern void *
+shared_heap_malloc(int size);
+extern void
+shared_heap_free(void *offset);
+extern void *
+test_addr_conv(void *ptr);
+
+int
+test()
+{
+    int *ptr = NULL;
+    int *ptr2 = NULL;
+
+    ptr = (int *)shared_heap_malloc(4);
+
+    if (ptr == NULL) {
+        return 0;
+    }
+    ptr2 = test_addr_conv(ptr);
+    if (ptr2 != ptr) {
+        return 0;
+    }
+    shared_heap_free(ptr);
+    return 1;
+}