gnh1201/welsonjs
1
0
Fork 0
mirror of https://github.com/gnh1201/welsonjs.git synced 2025-11-27 10:00:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Guard serial reads with timeout-based termination and cap

Browse Source
This commit is contained in:
Namhyeon, Go 2025-10-28 16:36:58 +09:00
parent 9f4219e971
commit 4489c31509
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
WelsonJS.Toolkit/WelsonJS.Launcher/SerialPortManager.cs
View File

@ -212,7 +212,7 @@ namespace WelsonJS.Launcher
using (var stream = new MemoryStream()) using (var stream = new MemoryStream())
{ {
var buffer = new byte[bufferSize]; var buffer = new byte[bufferSize];
const int MaxResponseBytes = 1 * 1024 * 1024; // 1 MiB safety cap
while (true) while (true)
{ {
try try
@ -220,18 +220,10 @@ namespace WelsonJS.Launcher
int read = await Task.Run(() => port.Read(buffer, 0, buffer.Length), token).ConfigureAwait(false); int read = await Task.Run(() => port.Read(buffer, 0, buffer.Length), token).ConfigureAwait(false);
if (read > 0) if (read > 0)
{ {
if (stream.Length + read > MaxResponseBytes)
throw new InvalidOperationException("Serial response exceeded maximum allowed size.");
stream.Write(buffer, 0, read); stream.Write(buffer, 0, read);
if (port.BytesToRead == 0) continue; // keep reading until idle timeout
{
break;
}
}
else
{
if (port.BytesToRead == 0)
{
break;
}
} }
} }
catch (TimeoutException) catch (TimeoutException)