From 9a8ee4d7f957043d24e5f5aa4ce45a07c7983c2f Mon Sep 17 00:00:00 2001 From: "Namhyeon, Go" Date: Mon, 31 Mar 2025 14:50:02 +0900 Subject: [PATCH] some updates --- .../WelsonJS.Launcher/EnvForm.Designer.cs | 2 +- WelsonJS.Toolkit/WelsonJS.Launcher/EnvForm.cs | 4 ++-- .../WelsonJS.Launcher/GlobalSettingsForm.cs | 21 ++++++++++++------- .../InstancesForm.Designer.cs | 2 +- .../WelsonJS.Launcher/InstancesForm.cs | 2 +- .../WelsonJS.Launcher/MainForm.cs | 2 +- 6 files changed, 20 insertions(+), 13 deletions(-) diff --git a/WelsonJS.Toolkit/WelsonJS.Launcher/EnvForm.Designer.cs b/WelsonJS.Toolkit/WelsonJS.Launcher/EnvForm.Designer.cs index c11de77..c8d4aaa 100644 --- a/WelsonJS.Toolkit/WelsonJS.Launcher/EnvForm.Designer.cs +++ b/WelsonJS.Toolkit/WelsonJS.Launcher/EnvForm.Designer.cs @@ -70,7 +70,7 @@ this.lvUserDefinedVariables.Size = new System.Drawing.Size(386, 129); this.lvUserDefinedVariables.TabIndex = 0; this.lvUserDefinedVariables.UseCompatibleStateImageBehavior = false; - this.lvUserDefinedVariables.SelectedIndexChanged += new System.EventHandler(this.ListView1_SelectedIndexChanged); + this.lvUserDefinedVariables.SelectedIndexChanged += new System.EventHandler(this.lvUserDefinedVariables_SelectedIndexChanged); // // columnHeader1 // diff --git a/WelsonJS.Toolkit/WelsonJS.Launcher/EnvForm.cs b/WelsonJS.Toolkit/WelsonJS.Launcher/EnvForm.cs index 4ffba2c..6802a97 100644 --- a/WelsonJS.Toolkit/WelsonJS.Launcher/EnvForm.cs +++ b/WelsonJS.Toolkit/WelsonJS.Launcher/EnvForm.cs @@ -30,7 +30,7 @@ namespace WelsonJS.Launcher lvUserDefinedVariables.FullRowSelect = true; lvUserDefinedVariables.Columns[0].Width = 150; lvUserDefinedVariables.Columns[1].Width = 220; - lvUserDefinedVariables.SelectedIndexChanged += ListView1_SelectedIndexChanged; + lvUserDefinedVariables.SelectedIndexChanged += lvUserDefinedVariables_SelectedIndexChanged; } // Load user-defined variables from the temporary folder in .env format @@ -98,7 +98,7 @@ namespace WelsonJS.Launcher } // Handle ListView selection change - private void ListView1_SelectedIndexChanged(object sender, EventArgs e) + private void lvUserDefinedVariables_SelectedIndexChanged(object sender, EventArgs e) { if (lvUserDefinedVariables.SelectedItems.Count > 0) { diff --git a/WelsonJS.Toolkit/WelsonJS.Launcher/GlobalSettingsForm.cs b/WelsonJS.Toolkit/WelsonJS.Launcher/GlobalSettingsForm.cs index b836a32..cba9b13 100644 --- a/WelsonJS.Toolkit/WelsonJS.Launcher/GlobalSettingsForm.cs +++ b/WelsonJS.Toolkit/WelsonJS.Launcher/GlobalSettingsForm.cs @@ -32,17 +32,24 @@ namespace WelsonJS.Launcher private void btnOkMaxScriptStatements_Click(object sender, EventArgs e) { - if (int.TryParse(txtMaxScriptStatements.Text, out int maxStatements)) + try { - using (RegistryKey key = Registry.CurrentUser.CreateSubKey(RegistryPath)) + if (int.TryParse(txtMaxScriptStatements.Text, out int maxStatements)) { - key.SetValue(RegistryKey, maxStatements, RegistryValueKind.DWord); + using (RegistryKey key = Registry.CurrentUser.CreateSubKey(RegistryPath)) + { + key.SetValue(RegistryKey, maxStatements, RegistryValueKind.DWord); + } + MessageBox.Show($"MaxScriptStatements setting has been changed to {maxStatements}.", "Confirmation", MessageBoxButtons.OK, MessageBoxIcon.Information); } - MessageBox.Show($"MaxScriptStatements setting has been changed to {maxStatements}.", "Confirmation", MessageBoxButtons.OK, MessageBoxIcon.Information); - } - else + else + { + MessageBox.Show("Please enter a valid number within the DWORD range.", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error); + } + } + catch (Exception ex) { - MessageBox.Show("Please enter a valid number within the DWORD range.", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error); + MessageBox.Show($"An error occurred while trying to change the MaxScriptStatements setting: {ex.Message}", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error); } } } diff --git a/WelsonJS.Toolkit/WelsonJS.Launcher/InstancesForm.Designer.cs b/WelsonJS.Toolkit/WelsonJS.Launcher/InstancesForm.Designer.cs index 212b3bf..042b0d0 100644 --- a/WelsonJS.Toolkit/WelsonJS.Launcher/InstancesForm.Designer.cs +++ b/WelsonJS.Toolkit/WelsonJS.Launcher/InstancesForm.Designer.cs @@ -116,7 +116,7 @@ this.cbUseSpecificScript.TabIndex = 7; this.cbUseSpecificScript.Text = "I want to use specific script "; this.cbUseSpecificScript.UseVisualStyleBackColor = true; - this.cbUseSpecificScript.CheckedChanged += new System.EventHandler(this.checkBox1_CheckedChanged); + this.cbUseSpecificScript.CheckedChanged += new System.EventHandler(this.cbUseSpecificScript_CheckedChanged); // // btnStart // diff --git a/WelsonJS.Toolkit/WelsonJS.Launcher/InstancesForm.cs b/WelsonJS.Toolkit/WelsonJS.Launcher/InstancesForm.cs index 40bfc52..0ba95da 100644 --- a/WelsonJS.Toolkit/WelsonJS.Launcher/InstancesForm.cs +++ b/WelsonJS.Toolkit/WelsonJS.Launcher/InstancesForm.cs @@ -133,7 +133,7 @@ namespace WelsonJS.Launcher } } - private void checkBox1_CheckedChanged(object sender, EventArgs e) + private void cbUseSpecificScript_CheckedChanged(object sender, EventArgs e) { txtUseSpecificScript.Enabled = cbUseSpecificScript.Checked; } diff --git a/WelsonJS.Toolkit/WelsonJS.Launcher/MainForm.cs b/WelsonJS.Toolkit/WelsonJS.Launcher/MainForm.cs index 7048c1c..289a93c 100644 --- a/WelsonJS.Toolkit/WelsonJS.Launcher/MainForm.cs +++ b/WelsonJS.Toolkit/WelsonJS.Launcher/MainForm.cs @@ -102,7 +102,7 @@ namespace WelsonJS.Launcher private void btnRunFromZipFile_Click(object sender, EventArgs e) { - using (OpenFileDialog openFileDialog = new OpenFileDialog()) + using (var openFileDialog = new OpenFileDialog()) { openFileDialog.Filter = "zip files (*.zip)|*.zip|All files (*.*)|*.*"; openFileDialog.FilterIndex = 2;