gnh1201/welsonjs
1
0
Fork 0
mirror of https://github.com/gnh1201/welsonjs.git synced 2025-10-26 18:41:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactor log file naming and improve Format method

Browse Source 
Changed log file naming to use <Namespace>.<random-6>.<PID>.log instead of including 'pid' in the filename. Moved file stream creation inside the Trace listener check. Reformatted and clarified the Format method for better readability and error handling.
This commit is contained in:
Namhyeon Go 2025-09-28 20:14:00 +09:00
parent ce84aab861
commit a35e101f23
1 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
WelsonJS.Toolkit/WelsonJS.Launcher/TraceLogger.cs
View File

@ -13,7 +13,7 @@ namespace WelsonJS.Launcher
{
/// <summary>
/// File-based trace logger.
/// Writes to %APPDATA%\WelsonJS\Logs\<Namespace>.<random-6>.pid<####>.log
/// Writes to %APPDATA%\WelsonJS\Logs\<Namespace>.<random-6>.<PID>.log
/// Falls back to current directory if %APPDATA%\WelsonJS\Logs cannot be created.
/// </summary>
public class TraceLogger : ICompatibleLogger
@ -42,13 +42,13 @@ namespace WelsonJS.Launcher
baseDir = AppDomain.CurrentDomain.BaseDirectory;
}
_logFilePath = Path.Combine(baseDir, $"{ns}.{suffix}.pid{pid}.log");
var fs = new FileStream(_logFilePath, FileMode.Append, FileAccess.Write, FileShare.Read);
var writer = new StreamWriter(fs) { AutoFlush = true };
_logFilePath = Path.Combine(baseDir, $"{ns}.{suffix}.{pid}.log");
if (!Trace.Listeners.OfType<TextWriterTraceListener>().Any())
{
var fs = new FileStream(_logFilePath, FileMode.Append, FileAccess.Write, FileShare.Read);
var writer = new StreamWriter(fs) { AutoFlush = true };
Trace.Listeners.Add(new TextWriterTraceListener(writer)
{
Name = "FileTraceListener",
@ -71,12 +71,19 @@ namespace WelsonJS.Launcher
private static string Format(object[] args)
{
if (args == null || args.Length == 0) return string.Empty;
if (args.Length == 1) return args[0]?.ToString() ?? string.Empty;
if (args == null || args.Length == 0)
return string.Empty;
if (args.Length == 1)
return args[0]?.ToString() ?? string.Empty;
string fmt = args[0]?.ToString() ?? string.Empty;
try { return string.Format(fmt, args.Skip(1).ToArray()); }
catch { return string.Join(" ", args.Select(a => a?.ToString() ?? "")); }
try {
return string.Format(fmt, args.Skip(1).ToArray());
}
catch {
return string.Join(" ", args.Select(a => a?.ToString() ?? ""));
}
}
private static string GenerateRandomSuffix(int length)