diff --git a/.pr_agent_accepted_suggestions.md b/.pr_agent_accepted_suggestions.md index 14b20d8..65de79e 100644 --- a/.pr_agent_accepted_suggestions.md +++ b/.pr_agent_accepted_suggestions.md @@ -1,3 +1,76 @@ +
                     PR 346 (2025-11-21)                     + +
+ + + +
[possible issue] Fix incorrect launcher shortcut path + +___ + +✅ Fix incorrect launcher shortcut path + +**Update the launcher shortcut path in the [Icons] section to include the bin subdirectory, changing the Filename to "{userappdata}\{cm:AppName}\bin\WelsonJS.Launcher.exe".** + +[setup.iss [79-82]](https://github.com/gnh1201/welsonjs/pull/346/files#diff-795027a3b21fc967567a1fd3cac4399554647a695eb7bee93e421bad0cabb55eR79-R82) + +```diff + [Icons] +-Name: "{group}\Start {cm:AppName} Launcher"; Filename: "{userappdata}\{cm:AppName}\WelsonJS.Launcher.exe"; AfterInstall: SetElevationBit('{group}\Start {cm:AppName} Launcher.lnk'); ++Name: "{group}\Start {cm:AppName} Launcher"; Filename: "{userappdata}\{cm:AppName}\bin\WelsonJS.Launcher.exe"; AfterInstall: SetElevationBit('{group}\Start {cm:AppName} Launcher.lnk'); + Name: "{group}\Test {cm:AppName}"; Filename: "{app}\bootstrap.bat"; AfterInstall: SetElevationBit('{group}\Test {cm:AppName}.lnk'); + Name: "{group}\Uninstall {cm:AppName}"; Filename: "{uninstallexe}"; AfterInstall: SetElevationBit('{group}\Uninstall {cm:AppName}.lnk'); +``` + + + + + +Suggestion importance[1-10]: 8 + +__ + +Why: The suggestion correctly identifies that the launcher shortcut path is missing the `bin` subdirectory, which would result in a broken shortcut after installation. + +___ + +
+ + + +
[possible issue] Fix incorrect file association path + +___ + +✅ Fix incorrect file association path + +**Correct the file association path in the [Registry] section by removing the x86 subfolder from the ValueData for the open command.** + +[setup.iss [39]](https://github.com/gnh1201/welsonjs/pull/346/files#diff-795027a3b21fc967567a1fd3cac4399554647a695eb7bee93e421bad0cabb55eR39-R39) + +```diff +-Root: HKCR; Subkey: "{cm:AppName}.Script\shell\open\command"; ValueType: string; ValueData: """{app}\bin\x86\WelsonJS.Launcher.exe"" --file ""%1"""; Flags: uninsdeletevalue ++Root: HKCR; Subkey: "{cm:AppName}.Script\shell\open\command"; ValueType: string; ValueData: """{app}\bin\WelsonJS.Launcher.exe"" --file ""%1"""; Flags: uninsdeletevalue +``` + + + + + +Suggestion importance[1-10]: 8 + +__ + +Why: The suggestion correctly points out that the file association registry key uses an outdated path with an `x86` subfolder, which would break the "Run with WelsonJS" context menu item. + +___ + +
+ +___ + + +
                     PR 343 (2025-11-15)                    
@@ -128,6 +201,8 @@ ___ + +
                     PR 339 (2025-10-28)                    
@@ -201,6 +276,8 @@ ___ + +
                     PR 336 (2025-10-13)                    
@@ -244,6 +321,8 @@ ___ + +
                     PR 335 (2025-10-10)                    
@@ -315,6 +394,8 @@ ___ + +
                     PR 334 (2025-10-03)                    
@@ -417,6 +498,8 @@ ___ + +
                     PR 330 (2025-09-28)                    
@@ -480,6 +563,8 @@ ___ + +
                     PR 323 (2025-08-26)                    
@@ -618,6 +703,8 @@ ___ + +
                     PR 320 (2025-08-20)                    
@@ -774,6 +861,8 @@ ___ + +
                     PR 318 (2025-08-17)                    
@@ -956,6 +1045,8 @@ ___ + +
                     PR 309 (2025-08-10)                     @@ -1014,6 +1105,8 @@ ___ + + @@ -1123,6 +1216,8 @@ ___ + + @@ -1211,6 +1306,8 @@ ___ + + @@ -1281,6 +1378,8 @@ ___ + + @@ -1348,6 +1447,8 @@ ___ + + @@ -1425,6 +1526,8 @@ ___ + + @@ -1513,6 +1616,8 @@ ___ + + @@ -1658,6 +1763,8 @@ ___ + + @@ -1772,6 +1879,8 @@ ___ + +