mirror of
https://github.com/gnh1201/welsonjs.git
synced 2025-11-27 18:11:20 +00:00
updated pr-agent best practices with auto analysis
parent
dfe128ee88
commit
543247d5f9
|
|
@ -1,3 +1,42 @@
|
|||
<!-- PR --><table><tr><td> <b><a href='https://github.com/gnh1201/welsonjs/pull/336#issuecomment-3395965215'>PR 336</a></b> (2025-10-13)
|
||||
|
||||
</td></tr></table>
|
||||
|
||||
|
||||
|
||||
<!-- suggestion --><details><summary>[general] Use trim() for whitespace removal</summary>
|
||||
|
||||
___
|
||||
|
||||
✅ Use trim() for whitespace removal
|
||||
|
||||
**Replace the replace calls with the more standard String.prototype.trim() method to remove whitespace from both ends of the path string.**
|
||||
|
||||
[lib/file.js [178]](https://github.com/gnh1201/welsonjs/pull/336/files#diff-387904f6b07263914bc1b0cb291a27832cc6963e01b5d44b75460771fc25ee8fR178-R178)
|
||||
|
||||
```diff
|
||||
-path = path.replace(/^\s+/, "").replace(/\s+$/, "");
|
||||
+path = path.trim();
|
||||
```
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
Suggestion importance[1-10]: 4
|
||||
|
||||
__
|
||||
|
||||
Why: The suggestion correctly proposes using `path.trim()` which is more readable and standard than using `replace` with regex for trimming whitespace.
|
||||
|
||||
___
|
||||
|
||||
</details>
|
||||
|
||||
___
|
||||
|
||||
|
||||
|
||||
<!-- PR --><table><tr><td> <b><a href='https://github.com/gnh1201/welsonjs/pull/335#issuecomment-3388120143'>PR 335</a></b> (2025-10-10)
|
||||
|
||||
</td></tr></table>
|
||||
|
|
@ -63,6 +102,8 @@ ___
|
|||
|
||||
|
||||
|
||||
|
||||
|
||||
<!-- PR --><table><tr><td> <b><a href='https://github.com/gnh1201/welsonjs/pull/334#issuecomment-3364799201'>PR 334</a></b> (2025-10-03)
|
||||
|
||||
</td></tr></table>
|
||||
|
|
@ -159,6 +200,8 @@ ___
|
|||
|
||||
|
||||
|
||||
|
||||
|
||||
<!-- PR --><table><tr><td> <b><a href='https://github.com/gnh1201/welsonjs/pull/330#issuecomment-3342945176'>PR 330</a></b> (2025-09-28)
|
||||
|
||||
</td></tr></table>
|
||||
|
|
@ -216,6 +259,8 @@ ___
|
|||
|
||||
|
||||
|
||||
|
||||
|
||||
<!-- PR --><table><tr><td> <b><a href='https://github.com/gnh1201/welsonjs/pull/323#issuecomment-3222497708'>PR 323</a></b> (2025-08-26)
|
||||
|
||||
</td></tr></table>
|
||||
|
|
@ -348,6 +393,8 @@ ___
|
|||
|
||||
|
||||
|
||||
|
||||
|
||||
<!-- PR --><table><tr><td> <b><a href='https://github.com/gnh1201/welsonjs/pull/320#issuecomment-3204803405'>PR 320</a></b> (2025-08-20)
|
||||
|
||||
</td></tr></table>
|
||||
|
|
@ -498,6 +545,8 @@ ___
|
|||
|
||||
|
||||
|
||||
|
||||
|
||||
<!-- PR --><table><tr><td> <b><a href='https://github.com/gnh1201/welsonjs/pull/318#issuecomment-3194328108'>PR 318</a></b> (2025-08-17)
|
||||
|
||||
</td></tr></table>
|
||||
|
|
@ -675,6 +724,8 @@ ___
|
|||
|
||||
|
||||
|
||||
|
||||
|
||||
<!-- PR --><table><tr><td> <b><a href='https://github.com/gnh1201/welsonjs/pull/309#issuecomment-3172799544'>PR 309</a></b> (2025-08-10)
|
||||
|
||||
</td></tr></table>
|
||||
|
|
@ -729,6 +780,8 @@ ___
|
|||
|
||||
|
||||
|
||||
|
||||
|
||||
<!-- PR --><table><tr><td> <b><a href='https://github.com/gnh1201/welsonjs/pull/307#issuecomment-3154116053'>PR 307</a></b> (2025-08-05)
|
||||
|
||||
</td></tr></table>
|
||||
|
|
@ -832,6 +885,8 @@ ___
|
|||
|
||||
|
||||
|
||||
|
||||
|
||||
<!-- PR --><table><tr><td> <b><a href='3055522397'>PR 284</a></b> (2025-07-10)
|
||||
|
||||
</td></tr></table>
|
||||
|
|
@ -913,6 +968,8 @@ ___
|
|||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
<!-- PR --><table><tr><td> <b><a href='3006712754'>PR 279</a></b> (2025-06-26)
|
||||
|
||||
|
|
@ -975,6 +1032,8 @@ ___
|
|||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
|
@ -1036,6 +1095,8 @@ ___
|
|||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
|
@ -1107,6 +1168,8 @@ ___
|
|||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
|
@ -1189,6 +1252,8 @@ ___
|
|||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
|
@ -1328,6 +1393,8 @@ ___
|
|||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
|
@ -1436,6 +1503,8 @@ ___
|
|||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user