mirror of
https://github.com/gnh1201/welsonjs.git
synced 2025-07-14 12:38:09 +00:00
updated pr-agent best practices with auto analysis
parent
e1b0f94513
commit
59438b7cb5
|
@ -1,3 +1,52 @@
|
||||||
|
<!-- PR --><table><tr><td> <b><a href='2953770469'>PR 272</a></b> (2025-06-08)
|
||||||
|
|
||||||
|
</td></tr></table>
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
<!-- suggestion --><details><summary>[general] Improve deprecation notice</summary>
|
||||||
|
|
||||||
|
___
|
||||||
|
|
||||||
|
✅ Improve deprecation notice
|
||||||
|
|
||||||
|
**
|
||||||
|
+ * @deprecated Use STD.EventTarget instead of STD.EventableObject
|
||||||
|
+ */
|
||||||
|
```
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
**Add a more descriptive deprecation notice that includes migration guidance. This helps developers understand why the feature is deprecated and how they should update their code.**
|
||||||
|
|
||||||
|
[lib/std.js [617-618]](https://github.com/gnh1201/welsonjs/pull/272/files#diff-fed60f70a945ad6b2f1f77def7fd34f63f5434f931067f710eba73263f4ee3abR617-R618)
|
||||||
|
|
||||||
|
```diff
|
||||||
|
-// @deprecated
|
||||||
|
+// @deprecated since v0.8.18 - Use exports.EventTarget instead of EventableObject
|
||||||
|
exports.EventableObject = StdEventTarget;
|
||||||
|
```
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
Suggestion importance[1-10]: 5
|
||||||
|
|
||||||
|
__
|
||||||
|
|
||||||
|
Why: The suggestion correctly improves the deprecation comment by adding version information and migration guidance. This enhances developer experience by providing clear direction on how to update their code, though it's a minor documentation improvement.
|
||||||
|
|
||||||
|
___
|
||||||
|
|
||||||
|
</details>
|
||||||
|
|
||||||
|
___
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
<!-- PR --><table><tr><td> <b><a href='2868572186'>PR 249</a></b> (2025-05-10)
|
<!-- PR --><table><tr><td> <b><a href='2868572186'>PR 249</a></b> (2025-05-10)
|
||||||
|
|
||||||
</td></tr></table>
|
</td></tr></table>
|
||||||
|
@ -56,6 +105,8 @@ ___
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
<!-- PR --><table><tr><td> <b><a href='2868568893'>PR 248</a></b> (2025-05-10)
|
<!-- PR --><table><tr><td> <b><a href='2868568893'>PR 248</a></b> (2025-05-10)
|
||||||
|
|
||||||
</td></tr></table>
|
</td></tr></table>
|
||||||
|
@ -171,6 +222,8 @@ ___
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
<!-- PR --><table><tr><td> <b><a href='2850302530'>PR 245</a></b> (2025-05-05)
|
<!-- PR --><table><tr><td> <b><a href='2850302530'>PR 245</a></b> (2025-05-05)
|
||||||
|
|
||||||
</td></tr></table>
|
</td></tr></table>
|
||||||
|
@ -255,6 +308,8 @@ ___
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
<!-- PR --><table><tr><td> <b><a href='2832883684'>PR 242</a></b> (2025-04-27)
|
<!-- PR --><table><tr><td> <b><a href='2832883684'>PR 242</a></b> (2025-04-27)
|
||||||
|
|
||||||
</td></tr></table>
|
</td></tr></table>
|
||||||
|
|
Loading…
Reference in New Issue
Block a user