gnh1201/seeddms-code
1
0
Fork 0
mirror of https://git.code.sf.net/p/seeddms/code synced 2025-06-01 14:37:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

proper check of return value of setStatus()

Browse Source
This commit is contained in:
Uwe Steinmann 2016-03-24 15:41:23 +01:00
parent f5db1b66cb
commit fe8e1d2b52
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
controllers/class.ReviseDocument.php
View File

@ -64,7 +64,7 @@ class SeedDMS_Controller_ReviseDocument extends SeedDMS_Controller_Common {
$result = $this->callHook('reviseUpdateDocumentStatus', $content); $result = $this->callHook('reviseUpdateDocumentStatus', $content);
if($result === null) { if($result === null) {
if ($revisionstatus == -1){ if ($revisionstatus == -1){
if($content->setStatus(S_REJECTED,$comment,$user)) { if(!$content->setStatus(S_REJECTED,$comment,$user)) {
$this->error = 1; $this->error = 1;
$this->errormsg = "revision_update_failed"; $this->errormsg = "revision_update_failed";
return false; return false;
@ -94,7 +94,7 @@ class SeedDMS_Controller_ReviseDocument extends SeedDMS_Controller_Common {
} }
} else { } else {
$newStatus=S_IN_REVISION; $newStatus=S_IN_REVISION;
if($content->setStatus($newStatus,$comment,$user)) { if(!$content->setStatus($newStatus,$comment,$user)) {
$this->error = 1; $this->error = 1;
$this->errormsg = "revision_update_failed"; $this->errormsg = "revision_update_failed";
return false; return false;