288 Commits

Author	SHA1	Message	Date
Marcin Kolny	9c2083a27f	Implement option for skipping function index in the callstack (#3785) ... Also add a script that converts instruction pointers to function indexes (or function names). https://github.com/bytecodealliance/wasm-micro-runtime/issues/3758	2024-09-11 16:08:37 +08:00
YAMAMOTO Takashi	f453d9d5ce	Appease GCC strict prototypes warning (#3775)	2024-09-10 09:42:23 +08:00
Marcin Kolny	cbc2078898	AOT call stack optimizations (#3773) ... - Implement TINY / STANDARD frame modes - tiny mode is only able to keep track on the IP and func idx, STANDARD mode provides more capabilities (parameters, stack pointer etc.). - Implement FRAME_PER_FUNCTION / FRAME_PER_CALL modes - frame per function adds code at the beginning and at the end of each function for allocating / deallocating stack frame, whereas in per-call mode the frame is allocated before each call. The exception is call to the imported function, where frame-per-function mode also allocates the stack before the `call` instruction (as it can't instrument the imported function). At the moment TINY + FRAME_PER_FUNCTION is automatically enabled in case GC and perf profiling are disabled and `values` call stack feature is not requested. In all the other cases STANDARD + FRAME_PER_CALL is used. STANDARD + FRAME_PER_FUNCTION and TINY + FRAME_PER_CALL are currently not implemented but possible, and might be enabled in the future. ps. https://github.com/bytecodealliance/wasm-micro-runtime/issues/3758	2024-09-10 09:05:23 +08:00
Marcin Kolny	6f97822c18	Add wamrc parameter to configure stack frame features (#3763) ... Those parameters can be used to reduce the size of the AOT code. There's going to be more changes related to AOT code size reduction, this is just the initial step. p.s. https://github.com/bytecodealliance/wasm-micro-runtime/issues/3758	2024-09-05 21:44:06 +08:00
Marcin Kolny	b4380fb3b1	refactoring: Re-use commit IP functionality between exception handling and other cases (#3768)	2024-09-05 16:18:47 +08:00
TianlongLiang	d1141f6f30	aot compiler: Allow to control stack boundary check when boundary check is enabled (#3754) ... In the AOT compiler, allow the user to control stack boundary check when the boundary check is enabled (e.g. `wamrc --bounds-checks=1`). Now the code logic is: 1. When `--stack-bounds-checks` is not set, it will be the same value as `--bounds-checks`. 2. When `--stack-bounds-checks` is set, it will be the option value no matter what the status of `--bounds-checks` is.	2024-08-29 11:08:39 +08:00
Anders Bakken	e8c2952bf9	Fix arm64 issues on mac (#3688) ... Make wamrc normalize "arm64" to "aarch64v8". Previously the only way to make the "arm64" target was to not specify a target on 64 bit arm-based mac builds. Now arm64 and aarch64v8 are treated as the same. Make aot_loader accept "aarch64v8" on arm-based apple (as well as accepting legacy "arm64" based aot targets). This also removes __APPLE__ and __MACH__ from the block that defaults size_level to 1 since it doesn't seem to be supported for aarch64: `LLVM ERROR: Only small, tiny and large code models are allowed on AArch64`	2024-08-23 09:49:06 +08:00
Wenyong Huang	1329e1d3e1	Add support for multi-memory proposal in classic interpreter (#3742) ... Implement multi-memory for classic-interpreter. Support core spec (and bulk memory) opcodes now, and will support atomic opcodes, and add multi-memory export APIs in the future. PS: Multi-memory spec test patched a lot for linking test to adapt for multi-module implementation.	2024-08-21 12:22:23 +08:00
YAMAMOTO Takashi	581e1d9767	compilation: Use the dedicated stack-sizes section only for AOT (#3732) ... For JIT, we naturally use mach-o on macOS, where the section name we currently use is not valid and ends up with the errors like: ``` LLVM ERROR: Global variable '__orc_lcl.aot_stack_sizes.0' has an invalid section specifier '.aot_stack_sizes': mach-o section specifier requires a segment and section separated by a comma. ``` Because the dedicated section is not necessary for JIT, this commit simply stops using it. Fixes: https://github.com/bytecodealliance/wasm-micro-runtime/issues/3730	2024-08-20 10:26:26 +08:00
Wenyong Huang	97c95a2e2f	Fix table idx resolving in op call_indirect/return_call_indirect (#3726) ... The table index in the call_indirect/return_call_indirect opcode should be one byte 0x00 when ref-types/GC isn't enabled, and should be treated as leb u32 when ref-types/GC is enabled. And make aot compiler bail out if ref-types/GC is disabled by command line argument while ref-types instructions are used.	2024-08-19 10:57:36 +08:00
Huang Qi	4c127715df	aot compiler: Fix NaN handling for opcode f32/f64.const in XIP mode (#3721) ... If the value of a float constant is an NaN, the aot compiler creates an alloca, stores the converted i32 const into it and then loads f32 from it again, which may introduce a relocation in the AOT file and is not allowed for XIP mode.	2024-08-16 14:04:41 +08:00
TianlongLiang	63df2cf02d	Update std atomic check and simd compatibility check for arc compiler (#3716)	2024-08-16 10:12:23 +08:00
James Ring	b845e2ede4	Add missing headers in bh_atomic.h and aot_llvm_extra.cpp (#3715)	2024-08-16 06:56:49 +08:00
Wenyong Huang	740f499e9c	Fix potential memory leak in insert_native_symbol (#3712)	2024-08-14 18:11:18 +08:00
Huang Qi	c3dd5598f6	Fix a compilation warning (#3682) ... Fix: ``` wamr/core/iwasm/compilation/aot_llvm.c: In function ‘insert_native_symbol’: wamr/core/iwasm/compilation/aot_llvm.c:3290:28: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare] 3290 | if (ret < 0 || ret + 1 > sizeof(sym->symbol)) { | ^ ``` Signed-off-by: Huang Qi <huangqi3@xiaomi.com>	2024-08-03 21:05:18 +08:00
YAMAMOTO Takashi	2f147fae96	aot compiler: Bail out on too long native symbol names (#3663) ... The old code was silently truncating long names.	2024-07-25 11:38:29 +08:00
YAMAMOTO Takashi	a055e0b26f	aot compiler: Enlarge AOTNativeSymbol->symbol (#3662) ... The old value was not enough for wasm_externref_obj_to_internal_obj, which is 34 characters long.	2024-07-25 11:21:07 +08:00
Wenyong Huang	73caf19e69	Fix compile warnings/error reported in Windows (#3616) ... Clear some compile warnings and fix undefined reference error for symbol ffs in Windows platform.	2024-07-12 16:43:22 +08:00
YAMAMOTO Takashi	867dbd8912	aot compiler: Propagate const-ness by ourselves (#3567) ... aot_load_const_from_table() hides the const-ness of the value and prevents optimizations like https://github.com/bytecodealliance/wasm-micro-runtime/pull/3552. This commit makes the aot compiler tracks the const-ness of the value directly in the AOTValue and enables the above mentioned optimization for XIP.	2024-06-25 10:57:49 +08:00
YAMAMOTO Takashi	e66b41427f	aot_resolve_target_info: Avoid in-place modification of e_type (#3564) ... * I believe that LLVM MemoryBuffer interface is supposed to be read-only and it's allowed to use eg. read-only mmap of the underlying file. It isn't appropriate to modify the view at all. * in case of WASM_ENABLE_DEBUG_AOT, the whole buffer is written as the text section of the aot file. the modified e_type would confuse dwarf consumers. note that, even when we are using XIP, the debug info usually contains relocations. for example, llvm-dwarfdump doesn't seem to perform relocations on .debug_info section for ET_CORE (== 4 == our E_TYPE_XIP) objects.	2024-06-25 10:47:23 +08:00
YAMAMOTO Takashi	4c2af25aff	aot compiler: Use larger alignment for load/store when possible (#3552) ... Consider the following wasm module: ```wast (module (func (export "foo") i32.const 0x104 i32.const 0x12345678 i32.store ) (memory 1 1) ) ``` While the address (0x104) is perfectly aligned for i32.store, as our aot compiler uses 1-byte alignment for load/store LLVM IR instructions, it often produces inefficient machine code, especially for alignment-sensitive targets. For example, the above "foo" function is compiled into the following xtensa machine code. ``` 0000002c <aot_func_internal#0>: 2c: 004136 entry a1, 32 2f: 07a182 movi a8, 0x107 32: 828a add.n a8, a2, a8 34: 291c movi.n a9, 18 36: 004892 s8i a9, a8, 0 39: 06a182 movi a8, 0x106 3c: 828a add.n a8, a2, a8 3e: ffff91 l32r a9, 3c <aot_func_internal#0+0x10> (ff91828a <aot_func_internal#0+0xff91825e>) 3e: R_XTENSA_SLOT0_OP .literal+0x8 41: 004892 s8i a9, a8, 0 44: 05a182 movi a8, 0x105 47: 828a add.n a8, a2, a8 49: ffff91 l32r a9, 48 <aot_func_internal#0+0x1c> (ffff9182 <aot_func_internal#0+0xffff9156>) 49: R_XTENSA_SLOT0_OP .literal+0xc 4c: 41a890 srli a10, a9, 8 4f: 0048a2 s8i a10, a8, 0 52: 04a182 movi a8, 0x104 55: 828a add.n a8, a2, a8 57: 004892 s8i a9, a8, 0 5a: f01d retw.n ``` Note that the each four bytes are stored separately using one-byte-store instruction, s8i. This commit tries to use larger alignments for load/store LLVM IR instructions when possible. with this commit, the above example is compiled into the following machine code, which seems more reasonable. ``` 0000002c <aot_func_internal#0>: 2c: 004136 entry a1, 32 2f: ffff81 l32r a8, 2c <aot_func_internal#0> (81004136 <aot_func_internal#0+0x8100410a>) 2f: R_XTENSA_SLOT0_OP .literal+0x8 32: 416282 s32i a8, a2, 0x104 35: f01d retw.n ``` Note: this doesn't work well for --xip because aot_load_const_from_table() hides the constness of the value. Maybe we need our own mechanism to propagate the constness and the value.	2024-06-22 10:32:52 +08:00
Wenyong Huang	9b9e938bee	Fix compilation errors (#3549) ... The compilation errors were introduced by #3515 and occur in debug building when wasm mini loader is compiled or GC is enabled. And remove two wasm files in standalone test-running-modes case, which will be generated by run.sh.	2024-06-20 12:33:52 +08:00
YAMAMOTO Takashi	a16da4f874	dwarf_extractor.cpp: Try to preserve link name (#3542) ... mainly for C++.	2024-06-19 16:51:44 +08:00
YAMAMOTO Takashi	7f94d183ac	dwarf_extractor.cpp: Fix buffer overruns (#3541) ... Probably it's better to skip the optimized out parameters. (that is, parameters w/o locations) However, I'm not sure how/if it can be done with the lldb api. For now, just disable parameter processing to avoid crashes.	2024-06-19 16:19:57 +08:00
Benbuck Nason	3746534010	Add table type API support (#3515) ... Add `wasm_runtime_get_export_table_inst` and `wasm_table_get_func_inst`, and related wasm_table_type_get_xxx APIs.	2024-06-19 14:50:46 +08:00
YAMAMOTO Takashi	72f74b7b51	dwarf_extractor.cpp: Enable limited support for C++ (#3540) ... While band-aid fixes like this is not plausible IMO, some people prefer to have some debug info even if it's partial/limited/broken. This commit partially (re)enables C++ processing. On the other hand, do not bother to process variables because it's known incompatible with C++.	2024-06-18 15:42:56 +08:00
YAMAMOTO Takashi	f096b2fa38	wamrc: Fix truncated DW_AT_producer (#3537)	2024-06-17 18:02:12 +08:00
Xenia Lu	ad5d31b9b0	Expose more functions related to emitting AOT files (#3520) ... - Add declarations related to emitting AOT files into a separate header file named `aot_emit_aot_file.h` - Add API `aot_emit_aot_file_buf_ex` and refactor `aot_emit_aot_file_buf` to call it - Expose some APIs in aot_export.h	2024-06-14 15:57:45 +08:00
Benbuck Nason	8239dd4aa7	Add wasm_export.h APIs to expose memory type (#3496) ... Support to get `wasm_memory_type_t memory_type` from API `wasm_runtime_get_import_type` and `wasm_runtime_get_export_type`, and then get shared flag, initial page cout, maximum page count from the memory_type: ```C bool wasm_memory_type_get_shared(const wasm_memory_type_t memory_type); uint32_t wasm_memory_type_get_init_page_count(const wasm_memory_type_t memory_type); uint32_t wasm_memory_type_get_max_page_count(const wasm_memory_type_t memory_type); ```	2024-06-06 09:20:24 +08:00
Wenyong Huang	23e1d51587	Fix loader parse block type and calculate dynamic offset for loop args (#3482) ... Fix several issues in wasm loader: - Parse a block's type index with leb int32 instead leb uint32 - Correct dst dynamic offset of loop block arguments for opcode br when copying the stack operands to the arguments of loop block - Free each frame_csp's param_frame_offsets when destroy loader ctx - Fix compilation error in wasm_mini_loader.c - Add test cases of failed issues This PR fixes issue #3467 and #3468.	2024-05-31 11:32:36 +08:00
TianlongLiang	30ed97cddc	Fix several typos and fix bh_log calculate mills (#3441)	2024-05-20 15:54:01 +08:00
YAMAMOTO Takashi	456e2f6919	aot compiler: Fix a type mismatch in compile_op_float_min_max (#3423) ... Fixes https://github.com/bytecodealliance/wasm-micro-runtime/issues/3422	2024-05-14 10:06:48 +08:00
YAMAMOTO Takashi	8f098a5905	aot: Make precheck functions use short-call for xtensa (#3418) ... Note: this breaks AOT ABI for xtensa again because of a revert of an ABI-breaking change.	2024-05-13 16:55:00 +08:00
Marcin Kolny	fe5e7a9981	Implement Memory64 support for AOT (#3362) ... Refer to: https://github.com/bytecodealliance/wasm-micro-runtime/pull/3266 https://github.com/bytecodealliance/wasm-micro-runtime/issues/3091	2024-05-13 11:03:38 +08:00
Benbuck Nason	c85bada2a9	Add wasm module global type information APIs (#3406) ... Support getting global type from `wasm_runtime_get_import_type` and `wasm_runtime_get_export_type`, and add two APIs: ```C wasm_valkind_t wasm_global_type_get_valkind(const wasm_global_type_t global_type); bool wasm_global_type_get_mutable(const wasm_global_type_t global_type); ```	2024-05-10 09:15:58 +08:00
YAMAMOTO Takashi	46f83cf486	core/iwasm/compilation: Remove stale function prototypes (#3408)	2024-05-09 16:55:32 +08:00
Benbuck Nason	1c2a8fca4e	Fix some more spelling issues (#3393)	2024-05-08 09:30:29 +08:00
Benbuck Nason	ca61184ced	Fix some spelling issues (#3385) ... Fix some of the spelling issues found by CSpell.	2024-05-06 07:56:48 +08:00
Wenyong Huang	835188cc53	aot compiler: Fix the length type passed to aot_memmove/aot_memset (#3378) ... The current length type of aot_memmove/aot_memset is size_t, and on a 64 bit host it is uint64, while what the aot code passes to it is uint32, this might lead to unexpected behavior. ps. https://github.com/bytecodealliance/wasm-micro-runtime/pull/3376.	2024-05-01 21:40:52 +08:00
Wenyong Huang	68bd30c6f9	Enhance GC subtyping checks (#3317) ... Enhance the GC subtyping checks: - Fix issues in the type equivalence check - Enable the recursive type subtyping check - Add a equivalence type flag in defined types of aot file, if there is an equivalence type before, just set it true and re-use the previous type - Normalize the defined types for interpreter and AOT - Enable spec test case type-equivalence.wast and type-subtyping.wast, and enable some commented cases - Enable set WAMR_BUILD_SANITIZER from cmake variable	2024-04-18 12:32:01 +08:00
liang.he	bcc2a2d2e1	Sync simd opcode definitions spec (#3290) ... Remove undefined simd opcodes.	2024-04-09 16:54:42 +08:00
liang.he	4ef724bbff	Enhance wasm loading with LoadArgs and support module names (#3265) ... - Add new API wasm_runtime_load_ex() in wasm_export.h and wasm_module_new_ex in wasm_c_api.h - Put aot_create_perf_map() into a separated file aot_perf_map.c - In perf.map, function names include user specified module name - Enhance the script to help flamegraph generations	2024-04-07 15:04:35 +08:00
Wenyong Huang	2013f1f7d7	Fix warnings/issues reported in Windows and by CodeQL/Coverity (#3275) ... Fix the warnings and issues reported: - in Windows platform - by CodeQL static code analyzing - by Coverity static code analyzing And update CodeQL script to build exception handling and memory features.	2024-04-07 11:57:31 +08:00
YAMAMOTO Takashi	53f0941ffa	Revert "lldb_function_to_function_dbi: A hack to avoid crashing on C++ methods (#3190)" (#3281) ... This reverts commit 0e8d949440. Because it doesn't make much sense anymore after we disabled debug info processing on C++ functions in: "aot debug: process lldb_function_to_function_dbi only for C".	2024-04-06 15:00:48 +08:00
YAMAMOTO Takashi	b4cab84e5f	aot debug: Process lldb_function_to_function_dbi only for C (#3278) ... This is a workaroud for: https://github.com/bytecodealliance/wasm-micro-runtime/issues/3187 https://github.com/bytecodealliance/wasm-micro-runtime/issues/3163	2024-04-03 18:03:31 +08:00
YAMAMOTO Takashi	dae09c0e03	aot debug: Fix a NULL dereference (#3274) ... It happens on eg. a C function taking a structure argument.	2024-04-03 17:10:46 +08:00
YAMAMOTO Takashi	4806e4e298	LLVM 19: Switch to debug records (#3272) ... References: https://llvm.org/docs/RemoveDIsDebugInfo.html https://github.com/llvm/llvm-project/pull/86529	2024-04-02 16:00:43 +08:00
YAMAMOTO Takashi	6b0b5de1c5	aot debug: Fix a few NULL dereferences on errors (#3273)	2024-04-02 14:30:08 +08:00
liang.he	498eb5d54a	Append \0 to every name string in aot name section (#3249) ... Since strings in .name section in .wasm is not c-style, need to append a `\0` to each string in .name section in AOT file when emitting.	2024-03-26 14:27:20 +08:00
liang.he	d8d8f8ce04	Implement apis to set and get the name of a wasm module (#3254) ... Add API wasm_runtime_set_module_name and wasm_runtime_get_module_name, and by default, a module's name is "" if the set module name api isn't called.	2024-03-26 12:10:13 +08:00