282 Commits

Author	SHA1	Message	Date
Anders Bakken	e8c2952bf9	Fix arm64 issues on mac (#3688) ... Make wamrc normalize "arm64" to "aarch64v8". Previously the only way to make the "arm64" target was to not specify a target on 64 bit arm-based mac builds. Now arm64 and aarch64v8 are treated as the same. Make aot_loader accept "aarch64v8" on arm-based apple (as well as accepting legacy "arm64" based aot targets). This also removes __APPLE__ and __MACH__ from the block that defaults size_level to 1 since it doesn't seem to be supported for aarch64: `LLVM ERROR: Only small, tiny and large code models are allowed on AArch64`	2024-08-23 09:49:06 +08:00
Wenyong Huang	1329e1d3e1	Add support for multi-memory proposal in classic interpreter (#3742) ... Implement multi-memory for classic-interpreter. Support core spec (and bulk memory) opcodes now, and will support atomic opcodes, and add multi-memory export APIs in the future. PS: Multi-memory spec test patched a lot for linking test to adapt for multi-module implementation.	2024-08-21 12:22:23 +08:00
YAMAMOTO Takashi	581e1d9767	compilation: Use the dedicated stack-sizes section only for AOT (#3732) ... For JIT, we naturally use mach-o on macOS, where the section name we currently use is not valid and ends up with the errors like: ``` LLVM ERROR: Global variable '__orc_lcl.aot_stack_sizes.0' has an invalid section specifier '.aot_stack_sizes': mach-o section specifier requires a segment and section separated by a comma. ``` Because the dedicated section is not necessary for JIT, this commit simply stops using it. Fixes: https://github.com/bytecodealliance/wasm-micro-runtime/issues/3730	2024-08-20 10:26:26 +08:00
Wenyong Huang	97c95a2e2f	Fix table idx resolving in op call_indirect/return_call_indirect (#3726) ... The table index in the call_indirect/return_call_indirect opcode should be one byte 0x00 when ref-types/GC isn't enabled, and should be treated as leb u32 when ref-types/GC is enabled. And make aot compiler bail out if ref-types/GC is disabled by command line argument while ref-types instructions are used.	2024-08-19 10:57:36 +08:00
Huang Qi	4c127715df	aot compiler: Fix NaN handling for opcode f32/f64.const in XIP mode (#3721) ... If the value of a float constant is an NaN, the aot compiler creates an alloca, stores the converted i32 const into it and then loads f32 from it again, which may introduce a relocation in the AOT file and is not allowed for XIP mode.	2024-08-16 14:04:41 +08:00
TianlongLiang	63df2cf02d	Update std atomic check and simd compatibility check for arc compiler (#3716)	2024-08-16 10:12:23 +08:00
James Ring	b845e2ede4	Add missing headers in bh_atomic.h and aot_llvm_extra.cpp (#3715)	2024-08-16 06:56:49 +08:00
Wenyong Huang	740f499e9c	Fix potential memory leak in insert_native_symbol (#3712)	2024-08-14 18:11:18 +08:00
Huang Qi	c3dd5598f6	Fix a compilation warning (#3682) ... Fix: ``` wamr/core/iwasm/compilation/aot_llvm.c: In function ‘insert_native_symbol’: wamr/core/iwasm/compilation/aot_llvm.c:3290:28: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare] 3290 | if (ret < 0 || ret + 1 > sizeof(sym->symbol)) { | ^ ``` Signed-off-by: Huang Qi <huangqi3@xiaomi.com>	2024-08-03 21:05:18 +08:00
YAMAMOTO Takashi	2f147fae96	aot compiler: Bail out on too long native symbol names (#3663) ... The old code was silently truncating long names.	2024-07-25 11:38:29 +08:00
YAMAMOTO Takashi	a055e0b26f	aot compiler: Enlarge AOTNativeSymbol->symbol (#3662) ... The old value was not enough for wasm_externref_obj_to_internal_obj, which is 34 characters long.	2024-07-25 11:21:07 +08:00
Wenyong Huang	73caf19e69	Fix compile warnings/error reported in Windows (#3616) ... Clear some compile warnings and fix undefined reference error for symbol ffs in Windows platform.	2024-07-12 16:43:22 +08:00
YAMAMOTO Takashi	867dbd8912	aot compiler: Propagate const-ness by ourselves (#3567) ... aot_load_const_from_table() hides the const-ness of the value and prevents optimizations like https://github.com/bytecodealliance/wasm-micro-runtime/pull/3552. This commit makes the aot compiler tracks the const-ness of the value directly in the AOTValue and enables the above mentioned optimization for XIP.	2024-06-25 10:57:49 +08:00
YAMAMOTO Takashi	e66b41427f	aot_resolve_target_info: Avoid in-place modification of e_type (#3564) ... * I believe that LLVM MemoryBuffer interface is supposed to be read-only and it's allowed to use eg. read-only mmap of the underlying file. It isn't appropriate to modify the view at all. * in case of WASM_ENABLE_DEBUG_AOT, the whole buffer is written as the text section of the aot file. the modified e_type would confuse dwarf consumers. note that, even when we are using XIP, the debug info usually contains relocations. for example, llvm-dwarfdump doesn't seem to perform relocations on .debug_info section for ET_CORE (== 4 == our E_TYPE_XIP) objects.	2024-06-25 10:47:23 +08:00
YAMAMOTO Takashi	4c2af25aff	aot compiler: Use larger alignment for load/store when possible (#3552) ... Consider the following wasm module: ```wast (module (func (export "foo") i32.const 0x104 i32.const 0x12345678 i32.store ) (memory 1 1) ) ``` While the address (0x104) is perfectly aligned for i32.store, as our aot compiler uses 1-byte alignment for load/store LLVM IR instructions, it often produces inefficient machine code, especially for alignment-sensitive targets. For example, the above "foo" function is compiled into the following xtensa machine code. ``` 0000002c <aot_func_internal#0>: 2c: 004136 entry a1, 32 2f: 07a182 movi a8, 0x107 32: 828a add.n a8, a2, a8 34: 291c movi.n a9, 18 36: 004892 s8i a9, a8, 0 39: 06a182 movi a8, 0x106 3c: 828a add.n a8, a2, a8 3e: ffff91 l32r a9, 3c <aot_func_internal#0+0x10> (ff91828a <aot_func_internal#0+0xff91825e>) 3e: R_XTENSA_SLOT0_OP .literal+0x8 41: 004892 s8i a9, a8, 0 44: 05a182 movi a8, 0x105 47: 828a add.n a8, a2, a8 49: ffff91 l32r a9, 48 <aot_func_internal#0+0x1c> (ffff9182 <aot_func_internal#0+0xffff9156>) 49: R_XTENSA_SLOT0_OP .literal+0xc 4c: 41a890 srli a10, a9, 8 4f: 0048a2 s8i a10, a8, 0 52: 04a182 movi a8, 0x104 55: 828a add.n a8, a2, a8 57: 004892 s8i a9, a8, 0 5a: f01d retw.n ``` Note that the each four bytes are stored separately using one-byte-store instruction, s8i. This commit tries to use larger alignments for load/store LLVM IR instructions when possible. with this commit, the above example is compiled into the following machine code, which seems more reasonable. ``` 0000002c <aot_func_internal#0>: 2c: 004136 entry a1, 32 2f: ffff81 l32r a8, 2c <aot_func_internal#0> (81004136 <aot_func_internal#0+0x8100410a>) 2f: R_XTENSA_SLOT0_OP .literal+0x8 32: 416282 s32i a8, a2, 0x104 35: f01d retw.n ``` Note: this doesn't work well for --xip because aot_load_const_from_table() hides the constness of the value. Maybe we need our own mechanism to propagate the constness and the value.	2024-06-22 10:32:52 +08:00
Wenyong Huang	9b9e938bee	Fix compilation errors (#3549) ... The compilation errors were introduced by #3515 and occur in debug building when wasm mini loader is compiled or GC is enabled. And remove two wasm files in standalone test-running-modes case, which will be generated by run.sh.	2024-06-20 12:33:52 +08:00
YAMAMOTO Takashi	a16da4f874	dwarf_extractor.cpp: Try to preserve link name (#3542) ... mainly for C++.	2024-06-19 16:51:44 +08:00
YAMAMOTO Takashi	7f94d183ac	dwarf_extractor.cpp: Fix buffer overruns (#3541) ... Probably it's better to skip the optimized out parameters. (that is, parameters w/o locations) However, I'm not sure how/if it can be done with the lldb api. For now, just disable parameter processing to avoid crashes.	2024-06-19 16:19:57 +08:00
Benbuck Nason	3746534010	Add table type API support (#3515) ... Add `wasm_runtime_get_export_table_inst` and `wasm_table_get_func_inst`, and related wasm_table_type_get_xxx APIs.	2024-06-19 14:50:46 +08:00
YAMAMOTO Takashi	72f74b7b51	dwarf_extractor.cpp: Enable limited support for C++ (#3540) ... While band-aid fixes like this is not plausible IMO, some people prefer to have some debug info even if it's partial/limited/broken. This commit partially (re)enables C++ processing. On the other hand, do not bother to process variables because it's known incompatible with C++.	2024-06-18 15:42:56 +08:00
YAMAMOTO Takashi	f096b2fa38	wamrc: Fix truncated DW_AT_producer (#3537)	2024-06-17 18:02:12 +08:00
Xenia Lu	ad5d31b9b0	Expose more functions related to emitting AOT files (#3520) ... - Add declarations related to emitting AOT files into a separate header file named `aot_emit_aot_file.h` - Add API `aot_emit_aot_file_buf_ex` and refactor `aot_emit_aot_file_buf` to call it - Expose some APIs in aot_export.h	2024-06-14 15:57:45 +08:00
Benbuck Nason	8239dd4aa7	Add wasm_export.h APIs to expose memory type (#3496) ... Support to get `wasm_memory_type_t memory_type` from API `wasm_runtime_get_import_type` and `wasm_runtime_get_export_type`, and then get shared flag, initial page cout, maximum page count from the memory_type: ```C bool wasm_memory_type_get_shared(const wasm_memory_type_t memory_type); uint32_t wasm_memory_type_get_init_page_count(const wasm_memory_type_t memory_type); uint32_t wasm_memory_type_get_max_page_count(const wasm_memory_type_t memory_type); ```	2024-06-06 09:20:24 +08:00
Wenyong Huang	23e1d51587	Fix loader parse block type and calculate dynamic offset for loop args (#3482) ... Fix several issues in wasm loader: - Parse a block's type index with leb int32 instead leb uint32 - Correct dst dynamic offset of loop block arguments for opcode br when copying the stack operands to the arguments of loop block - Free each frame_csp's param_frame_offsets when destroy loader ctx - Fix compilation error in wasm_mini_loader.c - Add test cases of failed issues This PR fixes issue #3467 and #3468.	2024-05-31 11:32:36 +08:00
TianlongLiang	30ed97cddc	Fix several typos and fix bh_log calculate mills (#3441)	2024-05-20 15:54:01 +08:00
YAMAMOTO Takashi	456e2f6919	aot compiler: Fix a type mismatch in compile_op_float_min_max (#3423) ... Fixes https://github.com/bytecodealliance/wasm-micro-runtime/issues/3422	2024-05-14 10:06:48 +08:00
YAMAMOTO Takashi	8f098a5905	aot: Make precheck functions use short-call for xtensa (#3418) ... Note: this breaks AOT ABI for xtensa again because of a revert of an ABI-breaking change.	2024-05-13 16:55:00 +08:00
Marcin Kolny	fe5e7a9981	Implement Memory64 support for AOT (#3362) ... Refer to: https://github.com/bytecodealliance/wasm-micro-runtime/pull/3266 https://github.com/bytecodealliance/wasm-micro-runtime/issues/3091	2024-05-13 11:03:38 +08:00
Benbuck Nason	c85bada2a9	Add wasm module global type information APIs (#3406) ... Support getting global type from `wasm_runtime_get_import_type` and `wasm_runtime_get_export_type`, and add two APIs: ```C wasm_valkind_t wasm_global_type_get_valkind(const wasm_global_type_t global_type); bool wasm_global_type_get_mutable(const wasm_global_type_t global_type); ```	2024-05-10 09:15:58 +08:00
YAMAMOTO Takashi	46f83cf486	core/iwasm/compilation: Remove stale function prototypes (#3408)	2024-05-09 16:55:32 +08:00
Benbuck Nason	1c2a8fca4e	Fix some more spelling issues (#3393)	2024-05-08 09:30:29 +08:00
Benbuck Nason	ca61184ced	Fix some spelling issues (#3385) ... Fix some of the spelling issues found by CSpell.	2024-05-06 07:56:48 +08:00
Wenyong Huang	835188cc53	aot compiler: Fix the length type passed to aot_memmove/aot_memset (#3378) ... The current length type of aot_memmove/aot_memset is size_t, and on a 64 bit host it is uint64, while what the aot code passes to it is uint32, this might lead to unexpected behavior. ps. https://github.com/bytecodealliance/wasm-micro-runtime/pull/3376.	2024-05-01 21:40:52 +08:00
Wenyong Huang	68bd30c6f9	Enhance GC subtyping checks (#3317) ... Enhance the GC subtyping checks: - Fix issues in the type equivalence check - Enable the recursive type subtyping check - Add a equivalence type flag in defined types of aot file, if there is an equivalence type before, just set it true and re-use the previous type - Normalize the defined types for interpreter and AOT - Enable spec test case type-equivalence.wast and type-subtyping.wast, and enable some commented cases - Enable set WAMR_BUILD_SANITIZER from cmake variable	2024-04-18 12:32:01 +08:00
liang.he	bcc2a2d2e1	Sync simd opcode definitions spec (#3290) ... Remove undefined simd opcodes.	2024-04-09 16:54:42 +08:00
liang.he	4ef724bbff	Enhance wasm loading with LoadArgs and support module names (#3265) ... - Add new API wasm_runtime_load_ex() in wasm_export.h and wasm_module_new_ex in wasm_c_api.h - Put aot_create_perf_map() into a separated file aot_perf_map.c - In perf.map, function names include user specified module name - Enhance the script to help flamegraph generations	2024-04-07 15:04:35 +08:00
Wenyong Huang	2013f1f7d7	Fix warnings/issues reported in Windows and by CodeQL/Coverity (#3275) ... Fix the warnings and issues reported: - in Windows platform - by CodeQL static code analyzing - by Coverity static code analyzing And update CodeQL script to build exception handling and memory features.	2024-04-07 11:57:31 +08:00
YAMAMOTO Takashi	53f0941ffa	Revert "lldb_function_to_function_dbi: A hack to avoid crashing on C++ methods (#3190)" (#3281) ... This reverts commit 0e8d949440. Because it doesn't make much sense anymore after we disabled debug info processing on C++ functions in: "aot debug: process lldb_function_to_function_dbi only for C".	2024-04-06 15:00:48 +08:00
YAMAMOTO Takashi	b4cab84e5f	aot debug: Process lldb_function_to_function_dbi only for C (#3278) ... This is a workaroud for: https://github.com/bytecodealliance/wasm-micro-runtime/issues/3187 https://github.com/bytecodealliance/wasm-micro-runtime/issues/3163	2024-04-03 18:03:31 +08:00
YAMAMOTO Takashi	dae09c0e03	aot debug: Fix a NULL dereference (#3274) ... It happens on eg. a C function taking a structure argument.	2024-04-03 17:10:46 +08:00
YAMAMOTO Takashi	4806e4e298	LLVM 19: Switch to debug records (#3272) ... References: https://llvm.org/docs/RemoveDIsDebugInfo.html https://github.com/llvm/llvm-project/pull/86529	2024-04-02 16:00:43 +08:00
YAMAMOTO Takashi	6b0b5de1c5	aot debug: Fix a few NULL dereferences on errors (#3273)	2024-04-02 14:30:08 +08:00
liang.he	498eb5d54a	Append \0 to every name string in aot name section (#3249) ... Since strings in .name section in .wasm is not c-style, need to append a `\0` to each string in .name section in AOT file when emitting.	2024-03-26 14:27:20 +08:00
liang.he	d8d8f8ce04	Implement apis to set and get the name of a wasm module (#3254) ... Add API wasm_runtime_set_module_name and wasm_runtime_get_module_name, and by default, a module's name is "" if the set module name api isn't called.	2024-03-26 12:10:13 +08:00
Wenyong Huang	ff296c1a62	Fix aot relocation symbols not found on windows 32-bit (#3231) ... The symbols in windows 32-bit may start with '_' and can not be found when resolving the relocations to them. This PR ignores the underscore when handling the relocation name of AOT_FUNC_INTERNAL_PREFIX, and redirect the relocation with name "_aot_stack_sizes" to the relocation with name ".aot_stack_sizes" (the name of the data section created). ps. https://github.com/bytecodealliance/wasm-micro-runtime/issues/3216	2024-03-18 09:51:38 +08:00
TianlongLiang	c3e33a96ea	Remove unused argument in wasm_runtime_lookup_function and refactor WASMModuleInstance (#3218) ... Remove the unused parameter `signature` from `wasm_runtime_lookup_function`. Refactor the layout of WASMModuleInstance structure: - move common data members `c_api_func_imports` and `cur_exec_env` from `WASMModuleInstanceExtraCommon` to `WASMModuleInstance` - In `WASMModuleInstance`, enlarge `reserved[3]` to `reserved[5]` in case that we need to add more fields in the future ps. https://github.com/bytecodealliance/wasm-micro-runtime/issues/2530 https://github.com/bytecodealliance/wasm-micro-runtime/issues/3202	2024-03-13 12:28:45 +08:00
Wenyong Huang	0ee5ffce85	Refactor APIs and data structures as preliminary work for Memory64 (#3209) ... # Change the data type representing linear memory address from u32 to u64 ## APIs signature changes - (Export)wasm_runtime_module_malloc - wasm_module_malloc - wasm_module_malloc_internal - aot_module_malloc - aot_module_malloc_internal - wasm_runtime_module_realloc - wasm_module_realloc - wasm_module_realloc_internal - aot_module_realloc - aot_module_realloc_internal - (Export)wasm_runtime_module_free - wasm_module_free - wasm_module_free_internal - aot_module_malloc - aot_module_free_internal - (Export)wasm_runtime_module_dup_data - wasm_module_dup_data - aot_module_dup_data - (Export)wasm_runtime_validate_app_addr - (Export)wasm_runtime_validate_app_str_addr - (Export)wasm_runtime_validate_native_addr - (Export)wasm_runtime_addr_app_to_native - (Export)wasm_runtime_addr_native_to_app - (Export)wasm_runtime_get_app_addr_range - aot_set_aux_stack - aot_get_aux_stack - wasm_set_aux_stack - wasm_get_aux_stack - aot_check_app_addr_and_convert, wasm_check_app_addr_and_convert and jit_check_app_addr_and_convert - wasm_exec_env_set_aux_stack - wasm_exec_env_get_aux_stack - wasm_cluster_create_thread - wasm_cluster_allocate_aux_stack - wasm_cluster_free_aux_stack ## Data structure changes - WASMModule and AOTModule - field aux_data_end, aux_heap_base and aux_stack_bottom - WASMExecEnv - field aux_stack_boundary and aux_stack_bottom - AOTCompData - field aux_data_end, aux_heap_base and aux_stack_bottom - WASMMemoryInstance(AOTMemoryInstance) - field memory_data_size and change __padding to is_memory64 - WASMModuleInstMemConsumption - field total_size and memories_size - WASMDebugExecutionMemory - field start_offset and current_pos - WASMCluster - field stack_tops ## Components that are affected by the APIs and data structure changes - libc-builtin - libc-emcc - libc-uvwasi - libc-wasi - Python and Go Language Embedding - Interpreter Debug engine - Multi-thread: lib-pthread, wasi-threads and thread manager	2024-03-12 11:38:50 +08:00
Wenyong Huang	b6216a5f8a	Fix ip (bytecode offset) not committed into the latest aot frame (#3213)	2024-03-11 18:11:43 +08:00
YAMAMOTO Takashi	0e8d949440	lldb_function_to_function_dbi: A hack to avoid crashing on C++ methods (#3190) ... Also, print the function name on argument mismatch.	2024-03-04 17:08:11 +08:00
TianlongLiang	cd63b3b8f2	Fix LLVM assertion failure and update CONTRIBUTING.md (#3197) ... The issue was reported in https://github.com/bytecodealliance/wasm-micro-runtime/issues/3188.	2024-03-04 09:01:40 +08:00