2302 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
YAMAMOTO Takashi	510bb11f4a	CI: make macos' build_samples_wasm_c_api similar to ubuntu (#4253)	2025-05-09 17:38:48 +08:00
James Ring	c48dd5ccd7	Don't call os_thread_get_stack_boundary unless we actually use it (#4264) ... Previously, if the user sets their own stack boundary, we still compute the thread stack boundary (which is expensive), then immediately discard the result. This change makes the expensive call only if we need it for sure.	2025-05-09 17:14:33 +08:00
liang.he	8f3961026e	fix: improve error handling of snprintf() in send_thread_stop_status() (#4234) ... Prevent `MAX_PACKET_SIZE - len` from overflowing.	2025-05-09 17:14:20 +08:00
YAMAMOTO Takashi	908838a5b5	build-scripts/build_llvm.py: bump to llvm 18 (#4259) ... * build-scripts/build_llvm.py: bump to llvm 18 cf. https://github.com/bytecodealliance/wasm-micro-runtime/issues/4210 why not 20? because, as of writing this, 19 is the latest released version for the xtensa fork of llvm: https://github.com/espressif/llvm-project why not 19? because of a bug in the xtensa fork of llvm: https://github.com/espressif/llvm-project/issues/112 while we can use different versions for different targets, it's nicer to use the same version everywhere when possible. * spec-test-script/runtest.py: --size-level=0 for x86-64 with the recent version of LLVM, wamrc --size-level=1 often generates R_X86_64_32S relocations which fail on load with the infamous error: "relocation truncated to fit R_X86_64_32S failed" it seems that these relocations are often for jump tables. this commit workarounds it with --size-level=0. an alternative is to disable jump tables. (although it seems that jump tables are not the only source of these relocations.) cf. https://github.com/bytecodealliance/wasm-micro-runtime/issues/3035 it might be better to do this in wamrc itself. however, currently target info is not available there in case of native compilation. related: https://github.com/bytecodealliance/wasm-micro-runtime/issues/3356 * wamr-compiler: size_level=0 for sgx mode cf. https://github.com/bytecodealliance/wasm-micro-runtime/issues/3035	2025-05-09 17:14:02 +08:00
liang.he	1a72dcf34f	Improve readlinkat_dup() to handle symlink size correctly (#4229) ... * In readlinkat_dup(), use fstatat() to estimate size first. * Reduce additional space in samples/file	2025-05-09 14:01:29 +08:00
YAMAMOTO Takashi	6aa223dbf3	Stop pretending to support extended-const proposal (#4258) ... As far as I know, we don't implement the proposal at all. ``` spacetanuki% wasm2wat --enable-all data.28.wasm (module (memory (;0;) 1) (data (;0;) (i32.const 42 i32.const 0 i32.sub) "")) spacetanuki% toywasm --load data.28.wasm spacetanuki% ~/git/wasm-micro-runtime/product-mini/platforms/darwin/b.classic/iwasm data.28.wasm WASM module load failed: illegal opcode or constant expression required or type mismatch spacetanuki% ``` data.28.wasm in the above example is a binary version of: 8d4f6aa2b0/test/core/data.wast (L184-L187)	2025-05-09 09:29:06 +08:00
YAMAMOTO Takashi	0a8994a2d5	aot_resolve_object_relocation_group: adapt to LLVM 19 (#4254) ... cf. https://github.com/llvm/llvm-project/pull/95031 https://github.com/llvm/llvm-project/pull/89693	2025-05-08 10:34:04 +08:00
YAMAMOTO Takashi	f88718d705	JIT: don't join worker threads twice (#4252) ... in case of WASM_ENABLE_LAZY_JIT==0, compile_jit_functions should have already joined these threads. joining them again here is an undefined behavior.	2025-05-08 10:24:55 +08:00
Chris Woods	ca5a2faf58	Modifying build flags to ensure libiwasm.so is built (#4255)	2025-05-08 10:13:09 +08:00
liang.he	216404d7cb	initialize WASI stdio handles to invalid for better error handling (#4092) ... * initialize WASI stdio handles to invalid for better error handling * implement os_invalid_raw_handle function for consistent invalid handle representation	2025-05-08 08:47:07 +08:00
Chris Woods	0e8b57d8a8	More detail to python setup, and fixed small typo (#4247)	2025-05-07 11:32:43 +08:00
YAMAMOTO Takashi	88b5f6a535	samples/wasm-c-api: remove unused valgrind detection (#4249) ... - it's unused - valgrind is basically a linux-only software. it isn't a good idea to make it a hard requirement. if we want to use valgrind, it's better to introduce a separate option to control it.	2025-05-07 11:32:29 +08:00
YAMAMOTO Takashi	ac2fe552d5	aot_resolve_object_relocation_group: adapt to LLVM 16 (#4250) ... cf. https://reviews.llvm.org/D123264	2025-05-07 11:32:14 +08:00
liang.he	ea417d7619	Add overflow check for preserved local offset in preserve_referenced_local (#4211)	2025-05-07 09:45:49 +08:00
YAMAMOTO Takashi	bb36a43fa4	riscv: avoid llvm.cttz.i32/i64 for xip (#4248) ... LLVM 16 and later expands cttz intrinsic to a table lookup, which involves some relocations. (unless ZBB is available, in which case the native instructions are preferred over the table-based lowering.) cf. https://reviews.llvm.org/D128911	2025-05-07 09:42:51 +08:00
YAMAMOTO Takashi	1996c18c4b	samples/wasm-c-api: skip aot compilation unless necessary (#4239)	2025-05-07 07:09:44 +08:00
dependabot[bot]	d053f5534a	build(deps): Bump github/codeql-action from 3.28.15 to 3.28.17 (#4243) ... Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.15 to 3.28.17. - [Release notes](https://github.com/github/codeql-action/releases) - [Commits](https://github.com/github/codeql-action/compare/v3.28.15...v3.28.17) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 3.28.17 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2025-05-06 11:16:45 +08:00
YAMAMOTO Takashi	4735956eeb	fix return types of our 64-bit clz/ctz/popcount intrinsics (#4238) ... the corresponding LLVM intrinsics' return types are same as their first argument. eg. i64 for llvm.cttz.i64. cf. https://llvm.org/docs/LangRef.html#llvm-cttz-intrinsic this commit changes the return types of our versions of the intrinsics to match llvm versions as our aot compiler, specifically __call_llvm_intrinsic, assumes. strictly speaking, this is a potential AOT ABI change. however, I suppose it isn't a problem for many of 64-bit ABIs out there, where (lower half of) a 64-bit register is used to return a 32-bit value anyway. (for such ABIs, this commit would fix the upper 32-bit value of the register.)	2025-05-06 10:15:00 +08:00
liang.he	5910e5cd21	Use --target to pass a triple in wamrc (#4199) ... Provide a triple string in the format of <arch>-<vendor>-<os>-<abi> via --target.	2025-05-06 06:56:06 +08:00
Huang Qi	5bdbba0dbe	platform/nuttx: Fix dcache operation in os_dcache_flush (#4225) ... Replace up_invalidate_dcache_all() with up_flush_dcache_all() in os_dcache_flush() to properly flush the data cache instead of just invalidating it. This ensures that any modified data in the cache is written back to memory before execution. Signed-off-by: Huang Qi <huangqi3@xiaomi.com>	2025-05-06 06:55:53 +08:00
YAMAMOTO Takashi	382aa9e6c3	run_clang_format_diff: mention homebrew for clang-format installation (#4237)	2025-05-06 06:55:42 +08:00
YAMAMOTO Takashi	3232bdf2f7	teach aot emitter/loader about .srodata and .srodata.cst* sections (#4240) ... LLVM 19 and later started to use srodata ("small read only data") sections for RISCV. cf. https://github.com/llvm/llvm-project/pull/82214 this commit makes our aot emitter/loader deal with those sections. an alternative would be to disable small data sections completely by setting the "SmallDataLimit" module attribute to zero. however, i feel this commit is more straightforward and consisitent as we are already dealing with sdata sections.	2025-05-06 06:55:35 +08:00
Liu Jia	9773390537	set default value of WAMR_BUILD_REF_TYPES to 1 in standalone cases (#4227) ... - set default value of WAMR_BUILD_REF_TYPES to 1 in CMakeLists.txt	2025-04-30 14:10:56 +08:00
liang.he	a9966897b6	use a selected llvm libs list to replace the full list (#4232)	2025-04-29 11:41:34 +08:00
liang.he	1d39b9c834	bypass vptr santizier (#4231) ... LLVM, by default, disables the use of C++'s built-in Run-Time Type Information. This decision is primarily driven by concerns about code size and efficiency. But '-fsanitize=vptr' not allowed with '-fno-rtti'.	2025-04-29 10:05:02 +08:00
liang.he	791e60f533	feat(fuzz): add a new fuzzing target about aot compiler (#4121) ... support llvm-jit running mode as another fuzzing target	2025-04-28 21:44:04 +08:00
YAMAMOTO Takashi	84767f9121	wamrc: add --disable-llvm-jump-tables option (#4224) ... while ideally a user should not need to care this kind of optimization details, in reality i guess it's sometimes useful. both of clang and GCC expose a similar option. (-fno-jump-tables)	2025-04-28 16:43:53 +08:00
YAMAMOTO Takashi	6593b3f347	LLVMCreateTargetMachineWithOpts: disable large data (#4220) ... for x86-64, llvm 17 and later sometimes uses "l" prefix for data sections. cf. 43249378da because our aot file emitter/loader doesn't support such sections, it ends up with load-time errors solving symbols like ".lrodata". this commit fixes it by avoid placing data in the large data sections. references: https://groups.google.com/g/x86-64-abi/c/jnQdJeabxiU 1feb00a28c	2025-04-27 11:48:57 +08:00
YAMAMOTO Takashi	c2d7fa30df	LLVM: don't verify instcombine fixpoint (#4219) ... LLVM 18 and later, instcombine perfoms only one iteration. it performs extra "verify fixpoint" operation when instcombine is specified in certain ways, including how we do so here. a problem is that the verification raises a fatal error when it finds we didn't reach a fixpoint: LLVM ERROR: Instruction Combining did not reach a fixpoint after 1 iterations while it should be rare, it's quite normal not to reach a fixpoint. this commit fixes the issue by simply disabing the verification. cf. 41895843b5	2025-04-27 11:30:35 +08:00
Liu Jia	af2a2040db	fix print_help when libc wasi is enabled (#4218)	2025-04-25 16:46:37 +08:00
Zhenwei Jin	6d61e72344	Update unit test cases (#4214) ... * Update gc unit test cases * Update aot stack frame unit test cases	2025-04-25 14:43:24 +08:00
Marcin Kolny	c883fafead	Merge pull request #4203 from jammar1/jammar1/fix-br-v128 ... Add missing V128 handling in WASM_OP_BR, reported in #4173	2025-04-22 14:47:08 +01:00
TianlongLiang	ff2768775c	fix potential memory leak (#4205)	2025-04-22 12:08:25 +08:00
James Marsh	0702f788fd	Add missing V128 handling in WASM_OP_BR, reported in #4173	2025-04-17 10:43:28 +01:00
liang.he	8f8c5605e9	Raise wasi-sdk to 25 and wabt to 1.0.37 (#4187) ... Raise wasi-sdk to 25 and wabt to 1.0.37. It includes - Refactor CI workflow to install WASI-SDK and WABT from a composite action - Use ExternalProject to bring wasm-apps for few samples. file/ wasi-threads/ - Refactor sample build and test steps in SGX compilation workflow for improved clarity and efficiency (workaround) Add CMake support for EMSCRIPTEN and WAMRC, update module paths	2025-04-17 16:41:47 +08:00
liang.he	ecb47d9326	Add missing casts and improve error handling in performance map functions (#4202) ... Wrong type of arguments to formatting function.	2025-04-17 15:22:23 +08:00
liang.he	996758cd4a	Remove the dlen to optimize it. (#4193) ... There are two reasons for this optimization: - The value of dlen can equal 0x1_0000_0000, even in wasm32 mode, because it is derived from (4G-0). This results in a truncation when it is passed to b_memmove_s(). Consequently, s1max becomes 0 and n is greater than s1max. To correct this, a longer type is required. - The dlen is only used to check if there is enough space in b_memmove_s(). However, from a different angle, after confirming that both src+len and dst+len are within the memory range, we can be assured and there is no need for this explicit check.	2025-04-17 15:21:02 +08:00
liang.he	fc1527eacd	Raise CI runner to ubuntu 22.04 (#4191) ... update workflows and scripts for Ubuntu 22.04 compatibility. It includes - install Intel SGX SDK 2.25 - use a reusable action to install sgx required - keep improve error handling in AOT compilation process in runtest.py add a workaround to fix receiving a shutdown signal problem. Refers to https://github.com/actions/runner-images/issues/6680 and https://github.com/actions/runner-images/discussions/7188	2025-04-17 15:07:46 +08:00
liang.he	955fce5664	Replace CMAKE_CURRENT_FUNCTION_LIST_DIR (#4200) ... `CMAKE_CURRENT_FUNCTION_LIST_DIR` is added in version 3.17 and currently most of `cmake_minimum_required()` with 3.14. Refer to https://cmake.org/cmake/help/latest/variable/CMAKE_CURRENT_FUNCTION_LIST_DIR.html	2025-04-17 00:07:25 +08:00
YAMAMOTO Takashi	0ba6532636	debug-engine: fix a few type mismatches (#4189) ... - use strict prototypes complained by GCC `-Wstrict-prototypes` - use `int*` instead of `int32*` Note: on some targets, int32_t is a long. for example, GCC shipped with the recent ESP-IDF has such a configuration. - https://github.com/apache/nuttx/issues/15755#issuecomment-2635652808 - https://github.com/apache/nuttx/pull/16022 - https://docs.espressif.com/projects/esp-idf/en/stable/esp32/migration-guides/release-5.x/5.0/gcc.html#espressif-toolchain-changes	2025-04-17 00:07:08 +08:00
a seven	fc78d67e15	Fix the error of AOT mode on the "i386-windows-msvc" platform (#4183) ... * Fix errors on the "i386-windows-msvc" platform * Refactor symbol name handling for AOT COFF32 binary format * Fix preprocessor directive placement for Windows compatibility in aot_reloc_x86_32.c --------- Co-authored-by: liang.he@intel.com <liang.he@intel.com>	2025-04-17 00:04:27 +08:00
liang.he	d085d1ccf7	Keep fix the CMake compatibility issue (#4180) ... ``` CMake Error at CMakeLists.txt:4 (cmake_minimum_required): Compatibility with CMake < 3.5 has been removed from CMake. Update the VERSION argument <min> value. Or, use the <min>...<max> syntax to tell CMake that the project requires at least <min> but has been updated to work with policies introduced by <max> or earlier. Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway. ```	2025-04-15 12:51:19 +08:00
YAMAMOTO Takashi	46ec863da3	fix false native stack overflow detections with HW_BOUND_CHECK (#4196) ... In call_wasm_with_hw_bound_check/call_native_with_hw_bound_check, ensure to set up the stack boundary (wasm_exec_env_set_thread_info) before checking the overflow. It seems that the problem was introduced by: https://github.com/bytecodealliance/wasm-micro-runtime/pull/2940	2025-04-15 11:48:48 +08:00
dependabot[bot]	3bdec3c54b	build(deps): Bump github/codeql-action from 3.28.14 to 3.28.15 (#4198) ... Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.14 to 3.28.15. - [Release notes](https://github.com/github/codeql-action/releases) - [Commits](https://github.com/github/codeql-action/compare/v3.28.14...v3.28.15) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 3.28.15 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2025-04-15 09:59:20 +08:00
Huang Qi	cc1903603d	fix: Remove unused variables in SIMD_v128_const case (#4197) ... Fix compiler warnings about unused variables `high` and `low` in the `SIMD_v128_const` case. These variables are only needed inside the `WASM_ENABLE_FAST_INTERP != 0` conditional block, but were incorrectly declared outside of it, causing unused variable warnings. Signed-off-by: Huang Qi <huangqi3@xiaomi.com>	2025-04-15 09:47:18 +08:00
liang.he	751cdcf073	improve variable naming and code clarity in SIMD operations (#4157) ... Fix compilation warning about shadow, like ```sh declaration of ‘val’ shadows a previous local [-Wshadow] ```	2025-04-10 14:36:20 +08:00
liang.he	9aaf3599ec	prevent frame_offset underflow in wasm_loader (#4165)	2025-04-10 12:06:06 +08:00
liang.he	793135b41c	Fix few integer overflowing (#4161) ... - fix(interpreter): correct offset calculations in wasm_loader_get_const_offset function - fix(mem-alloc): update offset calculation in gc_migrate for memory migration - add pointer-overflow sanitizer	2025-04-10 12:04:56 +08:00
TianlongLiang	8fe98f64c1	Add import memory/table flag assert check for miniloader (#4179)	2025-04-10 12:00:23 +08:00
liang.he	2a2632444b	Refactor Dockerfile and update .dockerignore for wasi-nn tests; adjust map-dir parameters in smoke test script (#4158)	2025-04-10 11:59:59 +08:00